You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@drill.apache.org by dz...@apache.org on 2023/02/09 15:38:22 UTC
[drill] branch master updated: DRILL-8397: Drill prints warnings to console when starting it (#2752)
This is an automated email from the ASF dual-hosted git repository.
dzamo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/drill.git
The following commit(s) were added to refs/heads/master by this push:
new 95e20f0237 DRILL-8397: Drill prints warnings to console when starting it (#2752)
95e20f0237 is described below
commit 95e20f0237b0eed0236573cd1d1c5458087f14ec
Author: Volodymyr Vysotskyi <vv...@gmail.com>
AuthorDate: Thu Feb 9 17:38:16 2023 +0200
DRILL-8397: Drill prints warnings to console when starting it (#2752)
---
common/src/test/resources/logback-test.xml | 9 +--
distribution/docker-cluster-mode/logback.xml | 9 +--
distribution/src/main/resources/logback.xml | 73 +++++++++++-----------
drill-yarn/src/test/resources/doy-test-logback.xml | 6 +-
4 files changed, 43 insertions(+), 54 deletions(-)
diff --git a/common/src/test/resources/logback-test.xml b/common/src/test/resources/logback-test.xml
index f47af26fd6..b1cf23b221 100644
--- a/common/src/test/resources/logback-test.xml
+++ b/common/src/test/resources/logback-test.xml
@@ -30,13 +30,11 @@
<RemoteHosts>${LILITH_HOSTNAME:-localhost}</RemoteHosts>
</appender>
- <logger name="org.apache.drill" additivity="false">
- <level value="debug"/>
+ <logger name="org.apache.drill" additivity="false" level="debug">
<appender-ref ref="SOCKET"/>
</logger>
- <logger name="query.logger" additivity="false">
- <level value="info"/>
+ <logger name="query.logger" additivity="false" level="info">
<appender-ref ref="SOCKET"/>
</logger>
-->
@@ -49,8 +47,7 @@
</encoder>
</appender>
- <root>
- <level value="error"/>
+ <root level="error">
<!-- Uncomment the next line (and the lines above) to be able to use Lilith for viewing log events -->
<!-- <appender-ref ref="SOCKET"/>-->
<!-- <appender-ref ref="STDOUT"/> -->
diff --git a/distribution/docker-cluster-mode/logback.xml b/distribution/docker-cluster-mode/logback.xml
index c1cdbfdd27..c907f7a075 100644
--- a/distribution/docker-cluster-mode/logback.xml
+++ b/distribution/docker-cluster-mode/logback.xml
@@ -24,16 +24,13 @@
<pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern>
</encoder>
</appender>
- <logger name="org.apache.drill" additivity="false">
- <level value="${DRILL_LOG_LEVEL:-info}" />
+ <logger name="org.apache.drill" additivity="false" level="${DRILL_LOG_LEVEL:-info}" >
<appender-ref ref="STDOUT" />
</logger>
- <logger name="query.logger" additivity="false">
- <level value="${DRILL_LOG_LEVEL:-info}" />
+ <logger name="query.logger" additivity="false" level="${DRILL_LOG_LEVEL:-info}">
<appender-ref ref="STDOUT" />
</logger>
- <root>
- <level value="${DRILL_LOG_LEVEL:-info}" />
+ <root level="${DRILL_LOG_LEVEL:-info}">
<appender-ref ref="STDOUT" />
</root>
</configuration>
diff --git a/distribution/src/main/resources/logback.xml b/distribution/src/main/resources/logback.xml
index 720826e17b..16bf2c7b7e 100644
--- a/distribution/src/main/resources/logback.xml
+++ b/distribution/src/main/resources/logback.xml
@@ -35,47 +35,45 @@
</encoder>
</appender>
- <appender name="QUERY" class="ch.qos.logback.core.rolling.RollingFileAppender">
- <file>${log.query.path}</file>
- <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy">
- <fileNamePattern>${log.query.path}.%i</fileNamePattern>
- <minIndex>1</minIndex>
- <maxIndex>10</maxIndex>
- </rollingPolicy>
-
- <triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy">
- <maxFileSize>100MB</maxFileSize>
- </triggeringPolicy>
- <encoder>
- <pattern>%msg%n</pattern>
- </encoder>
- </appender>
-
-
- <appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
- <file>${log.path}</file>
- <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy">
- <fileNamePattern>${log.path}.%i</fileNamePattern>
- <minIndex>1</minIndex>
- <maxIndex>10</maxIndex>
- </rollingPolicy>
-
- <triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy">
- <maxFileSize>100MB</maxFileSize>
- </triggeringPolicy>
- <encoder>
- <pattern>%date{ISO8601} [%thread] %-5level %logger{36} - %msg%n</pattern>
- </encoder>
- </appender>
+ <appender name="QUERY" class="ch.qos.logback.core.rolling.RollingFileAppender">
+ <file>${log.query.path}</file>
+ <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy">
+ <fileNamePattern>${log.query.path}.%i</fileNamePattern>
+ <minIndex>1</minIndex>
+ <maxIndex>10</maxIndex>
+ </rollingPolicy>
+
+ <triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy">
+ <maxFileSize>100MB</maxFileSize>
+ </triggeringPolicy>
+ <encoder>
+ <pattern>%msg%n</pattern>
+ </encoder>
+ </appender>
- <logger name="org.apache.drill" additivity="false">
- <level value="info" />
+ <appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
+ <file>${log.path}</file>
+ <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy">
+ <fileNamePattern>${log.path}.%i</fileNamePattern>
+ <minIndex>1</minIndex>
+ <maxIndex>10</maxIndex>
+ </rollingPolicy>
+
+ <triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy">
+ <maxFileSize>100MB</maxFileSize>
+ </triggeringPolicy>
+ <encoder>
+ <pattern>%date{ISO8601} [%thread] %-5level %logger{36} - %msg%n</pattern>
+ </encoder>
+ </appender>
+
+
+ <logger name="org.apache.drill" additivity="false" level="info">
<appender-ref ref="FILE" />
</logger>
- <logger name="query.logger" additivity="false">
- <level value="info" />
+ <logger name="query.logger" additivity="false" level="info">
<appender-ref ref="QUERY" />
<!-- <appender-ref ref="SOCKET" /> -->
</logger>
@@ -87,8 +85,7 @@
</logger>
-->
- <root>
- <level value="error" />
+ <root level="error">
<appender-ref ref="STDOUT" />
</root>
diff --git a/drill-yarn/src/test/resources/doy-test-logback.xml b/drill-yarn/src/test/resources/doy-test-logback.xml
index 2516c338d4..bbd1e65970 100644
--- a/drill-yarn/src/test/resources/doy-test-logback.xml
+++ b/drill-yarn/src/test/resources/doy-test-logback.xml
@@ -48,15 +48,13 @@
</rollingPolicy>
</appender>
-->
- <logger name="org.apache.drill" additivity="false">
- <level value="error" />
+ <logger name="org.apache.drill" additivity="false" level="error">
<!-- <appender-ref ref="SOCKET" /> -->
<appender-ref ref="STDOUT" />
<!-- <appender-ref ref="FILE" /> -->
</logger>
- <root>
- <level value="error" />
+ <root level="error">
<!-- <appender-ref ref="SOCKET" /> -->
<appender-ref ref="STDOUT" />
<!-- <appender-ref ref="FILE" /> -->