[jira] [Commented] (CALCITE-3775) Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

["Alon Eldar (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372065#comment-17372065 ] 

Alon Eldar commented on CALCITE-3775:
-------------------------------------

Looking at github I see a discussion ending in 20.02.21 without decisions on which approach to take with the PR.
I agree with zabetak's observation that one of the 2 options he suggested is needed.
Right now, if a user wants to disable caching with this line:
CreateRootSchema(..,false);
 his code suddenly fails unexpectedly without trivial debug options.
 which is what happened to me this week.
I think since case-insensitivity flag exists as part of the method's signature, the simple schema should support it, so I prefer option 1.
option 2 is also good if the approach is to keep it simpleSchema minimal. I can implement and commit option 2 if needed.

> Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
> --------------------------------------------------------------------------------
>
>                 Key: CALCITE-3775
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3775
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.21.0
>            Reporter: Stamatis Zampetakis
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 7h 50m
>  Remaining Estimate: 0h
>
> SimpleCalciteSchema contains methods for finding tables, sub-schemas, and types. The API allows to specify if the lookup will be case sensitive or insensitive but the respective parameter is ignored in the implementation of the method. 
> It is not a big problem since most of the time CachingCalciteSchema is used, which does not have this problem.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)