You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Jarek Gawor (JIRA)" <ji...@apache.org> on 2011/03/02 19:44:38 UTC

[jira] Created: (KARAF-496) Karaf prompt displayed twice

Karaf prompt displayed twice
----------------------------

                 Key: KARAF-496
                 URL: https://issues.apache.org/jira/browse/KARAF-496
             Project: Karaf
          Issue Type: Bug
          Components: console
    Affects Versions: 2.2.0, 2.1.4
         Environment: Windows
            Reporter: Jarek Gawor


When running Karaf on Windows with -Djline.terminal=jline.UnsupportedTerminal the Karaf prompt in the console is displayed twice after executing some command (i.e. pressing enter).

I believe the problem is in the jline library in ConsoleReader.readLine(InputStream) as the function will return after seeing first \r or \n. But on Windows \r\n is used as the EOL and the function does not consume the remaining \n.


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (KARAF-496) Karaf prompt displayed twice

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved KARAF-496.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0.0
                   2.2.2

> Karaf prompt displayed twice
> ----------------------------
>
>                 Key: KARAF-496
>                 URL: https://issues.apache.org/jira/browse/KARAF-496
>             Project: Karaf
>          Issue Type: Bug
>          Components: console
>    Affects Versions: 2.1.4, 2.2.0
>         Environment: Windows
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 2.2.2, 3.0.0
>
>
> When running Karaf on Windows with -Djline.terminal=jline.UnsupportedTerminal the Karaf prompt in the console is displayed twice after executing some command (i.e. pressing enter).
> I believe the problem is in the jline library in ConsoleReader.readLine(InputStream) as the function will return after seeing first \r or \n. But on Windows \r\n is used as the EOL and the function does not consume the remaining \n.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (KARAF-496) Karaf prompt displayed twice

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor reassigned KARAF-496:
---------------------------------

    Assignee: Jarek Gawor

> Karaf prompt displayed twice
> ----------------------------
>
>                 Key: KARAF-496
>                 URL: https://issues.apache.org/jira/browse/KARAF-496
>             Project: Karaf
>          Issue Type: Bug
>          Components: console
>    Affects Versions: 2.1.4, 2.2.0
>         Environment: Windows
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>
> When running Karaf on Windows with -Djline.terminal=jline.UnsupportedTerminal the Karaf prompt in the console is displayed twice after executing some command (i.e. pressing enter).
> I believe the problem is in the jline library in ConsoleReader.readLine(InputStream) as the function will return after seeing first \r or \n. But on Windows \r\n is used as the EOL and the function does not consume the remaining \n.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (KARAF-496) Karaf prompt displayed twice

Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006869#comment-13006869 ] 

Andreas Pieber commented on KARAF-496:
--------------------------------------

correction. I mean a different issue in linux :). This one is windows only (I can reproduce it)

> Karaf prompt displayed twice
> ----------------------------
>
>                 Key: KARAF-496
>                 URL: https://issues.apache.org/jira/browse/KARAF-496
>             Project: Karaf
>          Issue Type: Bug
>          Components: console
>    Affects Versions: 2.1.4, 2.2.0
>         Environment: Windows
>            Reporter: Jarek Gawor
>
> When running Karaf on Windows with -Djline.terminal=jline.UnsupportedTerminal the Karaf prompt in the console is displayed twice after executing some command (i.e. pressing enter).
> I believe the problem is in the jline library in ConsoleReader.readLine(InputStream) as the function will return after seeing first \r or \n. But on Windows \r\n is used as the EOL and the function does not consume the remaining \n.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (KARAF-496) Karaf prompt displayed twice

Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jamie goodyear closed KARAF-496.
--------------------------------


Fixed in Apache Karaf 2.2.2.

> Karaf prompt displayed twice
> ----------------------------
>
>                 Key: KARAF-496
>                 URL: https://issues.apache.org/jira/browse/KARAF-496
>             Project: Karaf
>          Issue Type: Bug
>          Components: console
>    Affects Versions: 2.1.4, 2.2.0
>         Environment: Windows
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 2.2.2, 3.0.0
>
>
> When running Karaf on Windows with -Djline.terminal=jline.UnsupportedTerminal the Karaf prompt in the console is displayed twice after executing some command (i.e. pressing enter).
> I believe the problem is in the jline library in ConsoleReader.readLine(InputStream) as the function will return after seeing first \r or \n. But on Windows \r\n is used as the EOL and the function does not consume the remaining \n.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (KARAF-496) Karaf prompt displayed twice

Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006861#comment-13006861 ] 

Andreas Pieber commented on KARAF-496:
--------------------------------------

I can reproduce this error also in the linux shell if I use -Djline.terminal=jline.UnsupportedTerminal. Let's see if I can get it running with a patched jline version

> Karaf prompt displayed twice
> ----------------------------
>
>                 Key: KARAF-496
>                 URL: https://issues.apache.org/jira/browse/KARAF-496
>             Project: Karaf
>          Issue Type: Bug
>          Components: console
>    Affects Versions: 2.1.4, 2.2.0
>         Environment: Windows
>            Reporter: Jarek Gawor
>
> When running Karaf on Windows with -Djline.terminal=jline.UnsupportedTerminal the Karaf prompt in the console is displayed twice after executing some command (i.e. pressing enter).
> I believe the problem is in the jline library in ConsoleReader.readLine(InputStream) as the function will return after seeing first \r or \n. But on Windows \r\n is used as the EOL and the function does not consume the remaining \n.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (KARAF-496) Karaf prompt displayed twice

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035413#comment-13035413 ] 

Jarek Gawor commented on KARAF-496:
-----------------------------------

I committed fixes for this problem to trunk (revision 1124286) and 2.2 branch (revision 1124287). I updated the jline.console.ConsoleReader to consume the extra LF character if there is one - much like what BufferedReader does.


> Karaf prompt displayed twice
> ----------------------------
>
>                 Key: KARAF-496
>                 URL: https://issues.apache.org/jira/browse/KARAF-496
>             Project: Karaf
>          Issue Type: Bug
>          Components: console
>    Affects Versions: 2.1.4, 2.2.0
>         Environment: Windows
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 2.2.2, 3.0.0
>
>
> When running Karaf on Windows with -Djline.terminal=jline.UnsupportedTerminal the Karaf prompt in the console is displayed twice after executing some command (i.e. pressing enter).
> I believe the problem is in the jline library in ConsoleReader.readLine(InputStream) as the function will return after seeing first \r or \n. But on Windows \r\n is used as the EOL and the function does not consume the remaining \n.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira