You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/09/18 21:20:33 UTC
Re: Review Request 68729: Simplified the weight lookup logic in the
sorters.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68729/
-----------------------------------------------------------
(Updated Sept. 18, 2018, 9:20 p.m.)
Review request for mesos, Gastón Kleiman and Meng Zhu.
Changes
-------
Updated the random sorter as well.
Summary (updated)
-----------------
Simplified the weight lookup logic in the sorters.
Repository: mesos
Description (updated)
-------
Simplified the weight lookup logic in the sorters.
Diffs (updated)
-----
src/master/allocator/sorter/drf/sorter.hpp 5a4fa5e2dca61168923261230b1f5c245354cbb7
src/master/allocator/sorter/drf/sorter.cpp 07e5482f37da8585d0313e9f70bd8105efa19533
src/master/allocator/sorter/random/sorter.hpp 7f6c0de70e3ae03d7362fb9e140b93435e530499
src/master/allocator/sorter/random/sorter.cpp d17f8afa96b66e63f56ccaa472ad398f8f517b65
Diff: https://reviews.apache.org/r/68729/diff/2/
Changes: https://reviews.apache.org/r/68729/diff/1-2/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 68729: Simplified the weight lookup logic in the
sorters.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68729/#review208735
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On Sept. 18, 2018, 2:20 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68729/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2018, 2:20 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Simplified the weight lookup logic in the sorters.
>
>
> Diffs
> -----
>
> src/master/allocator/sorter/drf/sorter.hpp 5a4fa5e2dca61168923261230b1f5c245354cbb7
> src/master/allocator/sorter/drf/sorter.cpp 07e5482f37da8585d0313e9f70bd8105efa19533
> src/master/allocator/sorter/random/sorter.hpp 7f6c0de70e3ae03d7362fb9e140b93435e530499
> src/master/allocator/sorter/random/sorter.cpp d17f8afa96b66e63f56ccaa472ad398f8f517b65
>
>
> Diff: https://reviews.apache.org/r/68729/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>