You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/07/27 13:50:50 UTC

[GitHub] [guacamole-client] necouchman commented on a change in pull request #630: GUACAMOLE-1386: Correct definitions of "Meta" and "Super" keys.

necouchman commented on a change in pull request #630:
URL: https://github.com/apache/guacamole-client/pull/630#discussion_r677467871



##########
File path: guacamole-common-js/src/main/webapp/modules/Keyboard.js
##########
@@ -583,7 +583,7 @@ Guacamole.Keyboard = function Keyboard(element) {
         "UIKeyInputUpArrow": [0xFF52],
         "Up": [0xFF52],
         "Undo": [0xFF65],
-        "Win": [0xFFEB],
+        "Win": [0xFFE7, 0xFFE7, 0xFFE8],

Review comment:
       Is there a reason that `0xFFE7` needs to be listed twice? I see this done for other keys that have multiple identifiers, just wondering why?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org