Re: [PR] feat(server): implement log rotation based on size and retention [iggy]

["Svecco (via GitHub)" <gi...@apache.org>]

Svecco commented on code in PR #2452:
URL: https://github.com/apache/iggy/pull/2452#discussion_r2656212083


##########
core/server/src/configs/defaults.rs:
##########
@@ -403,6 +403,8 @@ impl Default for LoggingConfig {
             level: SERVER_CONFIG.system.logging.level.parse().unwrap(),
             file_enabled: SERVER_CONFIG.system.logging.file_enabled,
             max_size: SERVER_CONFIG.system.logging.max_size.parse().unwrap(),
+            max_total_size: SERVER_CONFIG.system.logging.max_total_size.parse().unwrap(),
+            rotation_check_interval: SERVER_CONFIG.system.logging.rotation_check_interval as u64,

Review Comment:
   I have set the check interval to 1 hour and the upper limit of the rotation lifecycle to 7 days by default. Meanwhile, all default values have been streamlined to ensure they are determined by the integrated toml configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org