Re: [PR] [SPARK-53890][SDP] Test (and fix) read/readstream options are respected for pipelines [spark]

["AnishMahto (via GitHub)" <gi...@apache.org>]

AnishMahto commented on code in PR #53073:
URL: https://github.com/apache/spark/pull/53073#discussion_r2529220313


##########
sql/pipelines/src/test/scala/org/apache/spark/sql/pipelines/graph/ConnectValidPipelineSuite.scala:
##########
@@ -411,7 +411,7 @@ class ConnectValidPipelineSuite extends PipelineTest with SharedSparkSession {
       mem.addData(1, 2)
       registerPersistedView("complete-view", query = dfFlowFunc(Seq(1, 2).toDF("x")))
       registerPersistedView("incremental-view", query = dfFlowFunc(mem.toDF()))
-      registerTable("`complete-table`", query = Option(readFlowFunc("complete-view")))

Review Comment:
   With my changes we are actually parsing the identifier passed into `readFlowFunc` using the catalyst parser, hence why this invalid flow function name is only now throwing an invalid name exception. I am simply quoting the name to resolve this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org