[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3360: YARN-10909. AbstractCSQueue: add @VisibleForTesting annotation for test code

[GitBox <gi...@apache.org>]

szilard-nemeth commented on a change in pull request #3360:
URL: https://github.com/apache/hadoop/pull/3360#discussion_r706168489



##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
##########
@@ -1729,7 +1731,8 @@ public void updateLastSubmittedTimeStamp() {
     }
   }
 
-  public long getLastSubmittedTimestamp() {
+  @VisibleForTesting
+  long getLastSubmittedTimestamp() {

Review comment:
       As @TaoYang526 also pointed out in the jira, this is also being used by production code so the VisibleForTesting annotation is not applicable for this one.

##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
##########
@@ -1091,7 +1092,8 @@ Resource getQueueMaxResource(String nodePartition) {
     return getEffectiveMaxCapacity(nodePartition);
   }
 
-  public boolean hasChildQueues() {

Review comment:
       As @TaoYang526 also pointed out in the jira, this is also being used by production code so the VisibleForTesting annotation is not applicable for this one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org