You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by sh...@apache.org on 2009/12/10 08:54:13 UTC

svn commit: r889127 - in /lucene/solr/trunk/contrib/dataimporthandler: CHANGES.txt src/main/java/org/apache/solr/handler/dataimport/DocBuilder.java

Author: shalin
Date: Thu Dec 10 07:54:12 2009
New Revision: 889127

URL: http://svn.apache.org/viewvc?rev=889127&view=rev
Log:
SOLR-1639 -- Fixed misleading error message when dataimport.properties is not writable

Modified:
    lucene/solr/trunk/contrib/dataimporthandler/CHANGES.txt
    lucene/solr/trunk/contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/DocBuilder.java

Modified: lucene/solr/trunk/contrib/dataimporthandler/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/contrib/dataimporthandler/CHANGES.txt?rev=889127&r1=889126&r2=889127&view=diff
==============================================================================
--- lucene/solr/trunk/contrib/dataimporthandler/CHANGES.txt (original)
+++ lucene/solr/trunk/contrib/dataimporthandler/CHANGES.txt Thu Dec 10 07:54:12 2009
@@ -34,6 +34,7 @@
 * SOLR-1638: Fixed NullPointerException during import if uniqueKey is not specified
   in schema (Akshay Ukey via shalin)
 
+* SOLR-1639: Fixed misleading error message when dataimport.properties is not writable (shalin)
 
 Other Changes
 ----------------------

Modified: lucene/solr/trunk/contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/DocBuilder.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/DocBuilder.java?rev=889127&r1=889126&r2=889127&view=diff
==============================================================================
--- lucene/solr/trunk/contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/DocBuilder.java (original)
+++ lucene/solr/trunk/contrib/dataimporthandler/src/main/java/org/apache/solr/handler/dataimport/DocBuilder.java Thu Dec 10 07:54:12 2009
@@ -229,7 +229,13 @@
       if (requestParameters.optimize)
         addStatusMessage("Optimized");
     }
-    writer.persist(lastIndexTimeProps);
+    try {
+      writer.persist(lastIndexTimeProps);
+    } catch (Exception e) {
+      LOG.error("Could not write property file", e);
+      statusMessages.put("error", "Could not write property file. Delta imports will not work. " +
+          "Make sure your conf directory is writable");
+    }
   }
 
   void rollback() {