You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/03/04 23:19:40 UTC

[GitHub] [samza] xiefan46 commented on a change in pull request #1301: New kv metric

xiefan46 commented on a change in pull request #1301: New kv metric
URL: https://github.com/apache/samza/pull/1301#discussion_r387992768
 
 

 ##########
 File path: samza-api/src/main/java/org/apache/samza/metrics/SamzaHistogram.java
 ##########
 @@ -60,6 +60,11 @@ public void updateGaugeValues(double percentile) {
     gauges.get(percentile).set(values.getValue(percentile / 100));
   }
 
+  //for debug
+  public Map<Double, Gauge<Double>> getGauges() {
+    return gauges;
+  }
 
 Review comment:
   I will modify it and use a MetricsVisitor to get access to the Histogram instead of adding a getter method. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services