You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "xijiu (via GitHub)" <gi...@apache.org> on 2024/08/14 01:05:47 UTC

[PR] KAFKA-16818: Move event processing-related tests from ConsumerNetworkThreadTest to ApplicationEventProcessorTest [kafka]

xijiu opened a new pull request, #16875:
URL: https://github.com/apache/kafka/pull/16875

   The ConsumerNetworkThreadTest currently has a number of tests which do the following:
   
   1. Add event of type `T` to the event queue
   2. Call ConsumerNetworkThread.runOnce() to dequeue the events and call ApplicationEventProcessor.process()
   3. Verify that the appropriate ApplicationEventProcessor process method was invoked for the event
   
   Those types of tests should be moved to ApplicationEventProcessorTest.
   
   The methods that satisfies the conditions are
   
   - `testApplicationEventIsProcessed`
   - `testListOffsetsEventIsProcessed`
   - `testResetPositionsProcessFailureIsIgnored`
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-16818: Move event processing-related tests from ConsumerNetworkThreadTest to ApplicationEventProcessorTest [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16875:
URL: https://github.com/apache/kafka/pull/16875


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org