You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/16 17:00:17 UTC

[GitHub] [tvm] junrushao1994 commented on pull request #7153: [RUNTIME] Add libbacktrace for backtraces with line numbers

junrushao1994 commented on pull request #7153:
URL: https://github.com/apache/tvm/pull/7153#issuecomment-800440041


   It is super cool work that has been missing for years. It looks really nice and I don't have other concerns besides the ExternalProject approach, where the internet is required on the first build, which I (being nitpicky) think could cause some issues if the build environment doesn't have network connection. A better approach might be creating a repo under tlc-pack/octoml/etc and submodule it, like what synr does.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org