You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:29:32 UTC
[GitHub] [beam] epicfaace commented on a change in pull request #11797: [BEAM-10065] Fix beam release guide template
epicfaace commented on a change in pull request #11797:
URL: https://github.com/apache/beam/pull/11797#discussion_r430491681
##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
}
// Swapping visibility of code blocks.
- $(this.selector).hide();
+ $(this.selector).not(".language-md").hide();
Review comment:
```suggestion
$(this.selector).hide();
```
##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
}
// Swapping visibility of code blocks.
- $(this.selector).hide();
+ $(this.selector).not(".language-md").hide();
Review comment:
Accidentally added that change in -- removing it now
##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
}
// Swapping visibility of code blocks.
- $(this.selector).hide();
+ $(this.selector).not(".language-md").hide();
Review comment:
Otherwise, the template (which is in ` ```md`) becomes automatically hidden by this script. We can either add this change in, or we can disable syntax highlighting in the template by replacing ` ```md` with ` ``` `.
##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
}
// Swapping visibility of code blocks.
- $(this.selector).hide();
+ $(this.selector).not(".language-md").hide();
Review comment:
I don't think we'll ever have a language switcher with ` ```md ` code blocks, so this change should be safe to add.
##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
}
// Swapping visibility of code blocks.
- $(this.selector).hide();
+ $(this.selector).not(".language-md").hide();
Review comment:
```suggestion
$(this.selector).hide();
```
##########
File path: website/www/site/content/en/contribute/release-guide.md
##########
@@ -711,54 +711,54 @@ all major features and bug fixes, and all known issues.
Template:
-```
- We are happy to present the new {$RELEASE_VERSION} release of Beam. This release includes both improvements and new functionality.
- See the [download page](/get-started/downloads/{$DOWNLOAD_ANCHOR}) for this release.<!--more-->
- For more information on changes in {$RELEASE_VERSION}, check out the
- [detailed release notes]({$JIRA_RELEASE_NOTES}).
+```md
Review comment:
```suggestion
```
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org