You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/03 17:14:00 UTC
[jira] [Commented] (FLINK-4286) Have Kafka examples that use the
Kafka 0.9 connector
[ https://issues.apache.org/jira/browse/FLINK-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072731#comment-16072731 ]
ASF GitHub Bot commented on FLINK-4286:
---------------------------------------
Github user mylog00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3270#discussion_r125331370
--- Diff: flink-examples/flink-examples-streaming/pom.xml ---
@@ -360,6 +360,26 @@ under the License.
</configuration>
</execution>
+ <!--Kafka09-->
+ <execution>
+ <id>Kafka09</id>
+ <phase>package</phase>
+ <goals>
+ <goal>jar</goal>
+ </goals>
+ <configuration>
+ <classifier>Kafka09</classifier>
+ <archive>
+ <manifestEntries>
+ <program-class>org.apache.flink.streaming.examples.kafka.ReadFromKafka09</program-class>
+ </manifestEntries>
+ </archive>
+ <includes>
+ <include>org/apache/flink/streaming/examples/kafka/ReadFromKafka09.class</include>
+ <include>org/apache/flink/streaming/examples/kafka/WriteToKafka09.class</include>
+ </includes>
+ </configuration>
+ </execution>
--- End diff --
Yes. My bad. I did not check what examples can be executed via command line. And I shouldn't have had to remove fat-jar packager from pom.xml file (see next comment). But this PR has many conflicts, so I close It and will create new one.
> Have Kafka examples that use the Kafka 0.9 connector
> ----------------------------------------------------
>
> Key: FLINK-4286
> URL: https://issues.apache.org/jira/browse/FLINK-4286
> Project: Flink
> Issue Type: Improvement
> Components: Examples
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Dmitrii Kniazev
> Priority: Minor
> Labels: starter
>
> The {{ReadFromKafka}} and {{WriteIntoKafka}} examples use the 0.8 connector, and the built example jar is named {{Kafka.jar}} under {{examples/streaming/}} in the distributed package.
> Since we have different connectors for different Kafka versions, it would be good to have examples for different versions, and package them as {{Kafka08.jar}} and {{Kafka09.jar}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)