You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2014/10/15 13:48:31 UTC
Review Request 26740: Cleanup right angle bracket in the code base.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26740/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Till Toenshoff.
Bugs: MESOS-1872
https://issues.apache.org/jira/browse/MESOS-1872
Repository: mesos-git
Description
-------
make check
run grep -Hnr "> >" to identify the "> >" occurences in libprocess.
used a script to make the replacements and then checked the file diffs by hand.
Diffs
-----
3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
3rdparty/libprocess/include/process/collect.hpp 3bee8a6a0b7b48627ebc11c8b950b8582bba2c06
3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976
3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9
3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227
3rdparty/libprocess/include/process/event.hpp 294e2158876b25b06456a3619e547082d71e31ed
3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
3rdparty/libprocess/include/process/http.hpp 9cf05acbb724ab9af8010d1788621d37a0e48e86
3rdparty/libprocess/include/process/metrics/metric.hpp 00ace49bc5ef3914704c6247ece99474444960c9
3rdparty/libprocess/include/process/metrics/metrics.hpp aa44992762927870a5b609df1004027e8bf20eab
3rdparty/libprocess/include/process/mutex.hpp 3ff895510a5fbb06f93f768b1602bafd1eab81a9
3rdparty/libprocess/include/process/protobuf.hpp f3fc53985847a4c610fd63c91492619f0c6b8720
3rdparty/libprocess/include/process/queue.hpp 0403e251052f2a3f3e89296863acfcf1c08be4fb
3rdparty/libprocess/include/process/reap.hpp 9de5336376b281fd8929c7882ad0feaf69e6de1e
3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
3rdparty/libprocess/include/process/sequence.hpp d755b3422e8f04072893ef5678954dce828840f8
3rdparty/libprocess/include/process/shared.hpp 572ea2d5dce060193362030524e400641f87ec2e
3rdparty/libprocess/include/process/statistics.hpp 929fb8d544fe83edadbc856efca14177ae30315e
3rdparty/libprocess/include/process/subprocess.hpp 7ff5a10b21889a6ed3b0531731d664f9735196b9
3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
3rdparty/libprocess/src/metrics/metrics.cpp 38905d3e920288ac8c18ebed2743ebac9f438d2e
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
3rdparty/libprocess/src/reap.cpp ac14a868520ececb5fddc6162b0ea9c0f8c35ae3
3rdparty/libprocess/src/subprocess.cpp b92692388110dbc429dd3a855baa1b5191693e70
3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
3rdparty/libprocess/src/tests/reap_tests.cpp a18d54c43fba44d084e722abdc67d32e5d4504e4
3rdparty/libprocess/src/tests/shared_tests.cpp 1df67b4c85d4567cf22922ac339f687832784594
3rdparty/libprocess/src/tests/statistics_tests.cpp 0e4960a4e2e807ee9f3f6d83cdbfa6b563352760
Diff: https://reviews.apache.org/r/26740/diff/
Testing
-------
Thanks,
Evelina Dumitrescu
Re: Review Request 26740: libprocess: Cleanup right angle bracket in
the code base.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26740/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 11:57 a.m.)
Review request for mesos, Jie Yu and Till Toenshoff.
Bugs: MESOS-1872
https://issues.apache.org/jira/browse/MESOS-1872
Repository: mesos-git
Description (updated)
-------
Replaced > > with >> to be consistent with the C++ 11 standarad.
Diffs
-----
3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
3rdparty/libprocess/include/process/collect.hpp 3bee8a6a0b7b48627ebc11c8b950b8582bba2c06
3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976
3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9
3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227
3rdparty/libprocess/include/process/event.hpp 294e2158876b25b06456a3619e547082d71e31ed
3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
3rdparty/libprocess/include/process/http.hpp 9cf05acbb724ab9af8010d1788621d37a0e48e86
3rdparty/libprocess/include/process/metrics/metric.hpp 00ace49bc5ef3914704c6247ece99474444960c9
3rdparty/libprocess/include/process/metrics/metrics.hpp aa44992762927870a5b609df1004027e8bf20eab
3rdparty/libprocess/include/process/mutex.hpp 3ff895510a5fbb06f93f768b1602bafd1eab81a9
3rdparty/libprocess/include/process/protobuf.hpp f3fc53985847a4c610fd63c91492619f0c6b8720
3rdparty/libprocess/include/process/queue.hpp 0403e251052f2a3f3e89296863acfcf1c08be4fb
3rdparty/libprocess/include/process/reap.hpp 9de5336376b281fd8929c7882ad0feaf69e6de1e
3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
3rdparty/libprocess/include/process/sequence.hpp d755b3422e8f04072893ef5678954dce828840f8
3rdparty/libprocess/include/process/shared.hpp 572ea2d5dce060193362030524e400641f87ec2e
3rdparty/libprocess/include/process/statistics.hpp 929fb8d544fe83edadbc856efca14177ae30315e
3rdparty/libprocess/include/process/subprocess.hpp 7ff5a10b21889a6ed3b0531731d664f9735196b9
3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
3rdparty/libprocess/src/metrics/metrics.cpp 38905d3e920288ac8c18ebed2743ebac9f438d2e
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
3rdparty/libprocess/src/reap.cpp ac14a868520ececb5fddc6162b0ea9c0f8c35ae3
3rdparty/libprocess/src/subprocess.cpp b92692388110dbc429dd3a855baa1b5191693e70
3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
3rdparty/libprocess/src/tests/reap_tests.cpp a18d54c43fba44d084e722abdc67d32e5d4504e4
3rdparty/libprocess/src/tests/shared_tests.cpp 1df67b4c85d4567cf22922ac339f687832784594
3rdparty/libprocess/src/tests/statistics_tests.cpp 0e4960a4e2e807ee9f3f6d83cdbfa6b563352760
Diff: https://reviews.apache.org/r/26740/diff/
Testing (updated)
-------
make check
run grep -Hnr "> >" to identify the "> >" occurences in libprocess.
used a script to make the replacements and then checked the file diffs by hand.
Thanks,
Evelina Dumitrescu
Re: Review Request 26740: libprocess: Cleanup right angle bracket in
the code base.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26740/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 11:56 a.m.)
Review request for mesos, Jie Yu and Till Toenshoff.
Summary (updated)
-----------------
libprocess: Cleanup right angle bracket in the code base.
Bugs: MESOS-1872
https://issues.apache.org/jira/browse/MESOS-1872
Repository: mesos-git
Description
-------
make check
run grep -Hnr "> >" to identify the "> >" occurences in libprocess.
used a script to make the replacements and then checked the file diffs by hand.
Diffs
-----
3rdparty/libprocess/include/process/async.hpp 9af3cc07334eb7dc26b73964c447cc9b9799396c
3rdparty/libprocess/include/process/collect.hpp 3bee8a6a0b7b48627ebc11c8b950b8582bba2c06
3rdparty/libprocess/include/process/defer.hpp ebe6f2db47cab2a3306288d8ebabb720e7cd8976
3rdparty/libprocess/include/process/delay.hpp 487f652c9e9b7c8c3aa8b4edc9e59789cffd8da9
3rdparty/libprocess/include/process/dispatch.hpp bceda2a2ae8963921e8e19660243a8644feab227
3rdparty/libprocess/include/process/event.hpp 294e2158876b25b06456a3619e547082d71e31ed
3rdparty/libprocess/include/process/future.hpp 46ae16b0bbce79005f5ed8711be663eeeb8f4bcf
3rdparty/libprocess/include/process/help.hpp 07e99f1124c60003f4c8b8e6cdcb193bb3577496
3rdparty/libprocess/include/process/http.hpp 9cf05acbb724ab9af8010d1788621d37a0e48e86
3rdparty/libprocess/include/process/metrics/metric.hpp 00ace49bc5ef3914704c6247ece99474444960c9
3rdparty/libprocess/include/process/metrics/metrics.hpp aa44992762927870a5b609df1004027e8bf20eab
3rdparty/libprocess/include/process/mutex.hpp 3ff895510a5fbb06f93f768b1602bafd1eab81a9
3rdparty/libprocess/include/process/protobuf.hpp f3fc53985847a4c610fd63c91492619f0c6b8720
3rdparty/libprocess/include/process/queue.hpp 0403e251052f2a3f3e89296863acfcf1c08be4fb
3rdparty/libprocess/include/process/reap.hpp 9de5336376b281fd8929c7882ad0feaf69e6de1e
3rdparty/libprocess/include/process/run.hpp 924d31a7d1bba0a6ecd8be8d622a3ae1faebe042
3rdparty/libprocess/include/process/sequence.hpp d755b3422e8f04072893ef5678954dce828840f8
3rdparty/libprocess/include/process/shared.hpp 572ea2d5dce060193362030524e400641f87ec2e
3rdparty/libprocess/include/process/statistics.hpp 929fb8d544fe83edadbc856efca14177ae30315e
3rdparty/libprocess/include/process/subprocess.hpp 7ff5a10b21889a6ed3b0531731d664f9735196b9
3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2
3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
3rdparty/libprocess/src/metrics/metrics.cpp 38905d3e920288ac8c18ebed2743ebac9f438d2e
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
3rdparty/libprocess/src/reap.cpp ac14a868520ececb5fddc6162b0ea9c0f8c35ae3
3rdparty/libprocess/src/subprocess.cpp b92692388110dbc429dd3a855baa1b5191693e70
3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b
3rdparty/libprocess/src/tests/reap_tests.cpp a18d54c43fba44d084e722abdc67d32e5d4504e4
3rdparty/libprocess/src/tests/shared_tests.cpp 1df67b4c85d4567cf22922ac339f687832784594
3rdparty/libprocess/src/tests/statistics_tests.cpp 0e4960a4e2e807ee9f3f6d83cdbfa6b563352760
Diff: https://reviews.apache.org/r/26740/diff/
Testing
-------
Thanks,
Evelina Dumitrescu