You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/29 02:21:26 UTC
[GitHub] [spark] maropu edited a comment on issue #25281:
[SPARK-28549][BUILD][CORE][SQL] Use `text.StringEscapeUtils` instead
`lang3.StringEscapeUtils`
maropu edited a comment on issue #25281: [SPARK-28549][BUILD][CORE][SQL] Use `text.StringEscapeUtils` instead `lang3.StringEscapeUtils`
URL: https://github.com/apache/spark/pull/25281#issuecomment-515821098
I checked them by myself and I found that this pr includes all the needed entries;
```
(base) maropu@~/Repositories/spark/spark-master: (master $%=)$find . -type f | grep -e "\.scala$" | xargs grep org.apache.commons.lang3.StringEscapeUtils
./core/src/main/scala/org/apache/spark/ui/HttpSecurityFilter.scala:import org.apache.commons.lang3.StringEscapeUtils
./core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala:import org.apache.commons.lang3.StringEscapeUtils
./core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala:import org.apache.commons.lang3.StringEscapeUtils
./core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala:import org.apache.commons.lang3.StringEscapeUtils
./core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala:import org.apache.commons.lang3.StringEscapeUtils
./core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala:import org.apache.commons.lang3.StringEscapeUtils
./repl/src/test/scala/org/apache/spark/repl/SingletonReplSuite.scala:import org.apache.commons.lang3.StringEscapeUtils
./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala:import org.apache.commons.lang3.StringEscapeUtils
./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala:import org.apache.commons.lang3.StringEscapeUtils
./sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala:import org.apache.commons.lang3.StringEscapeUtils
./sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala:import org.apache.commons.lang3.StringEscapeUtils
./sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala:import org.apache.commons.lang3.StringEscapeUtils
./streaming/src/main/scala/org/apache/spark/streaming/ui/BatchPage.scala:import org.apache.commons.lang3.StringEscapeUtils
./streaming/src/main/scala/org/apache/spark/streaming/ui/UIUtils.scala:import org.apache.commons.lang3.StringEscapeUtils
```
The fix looks fine to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org