[jira] [Commented] (THRIFT-3972) Remove unused mutex code from the C++ library to reduce the maintenance overhead of the project

["James E. King, III (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15661458#comment-15661458 ] 

James E. King, III commented on THRIFT-3972:
--------------------------------------------

[~nsuke] It looks like ReadWriteMutex is currently used by {{apache/thrift/contrib/fb303/cpp/FacebookBase.h}}.  I'm not familiar with that.  Do we need to continue to maintain fb303?  If so, the class ReadWriteMutex needs to stay or be moved into fb303.  There are no mentions of RWGuard or NoStarveReadWriteMutex in the project and those can be safely removed.

> Remove unused mutex code from the C++ library to reduce the maintenance overhead of the project
> -----------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3972
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3972
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.10.0
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>            Priority: Minor
>
> As part of looking into THRIFT-3038 a couple of unused classes were identified, and it was suggested we use a different ticket to track their removal:
> NoStarveReadWriteMutex
> ReadWriteMutex
> RWGuard
> Thrift's mission is to make cross-platform/cross-language RPC easy and not to provide a cross-platform concurrency library, so there is no need to keep unused concurrency related code in the project.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)