You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "jgallimore (via GitHub)" <gi...@apache.org> on 2026/08/19 11:18:48 UTC

[PR] TOMEE-4682 TomEESecurityContext.authenticate() should delegate to Htt… (tomee)

jgallimore opened a new pull request, #2902:
URL: https://github.com/apache/tomee/pull/2902

   …pServletRequest as opposed to invoking JASPIC directly. Includes 2 new examples demonstrating 2FA using passkeys.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TOMEE-4682 TomEESecurityContext.authenticate() should delegate to Htt… (tomee)

Posted by "exabrial (via GitHub)" <gi...@apache.org>.
exabrial commented on PR #2902:
URL: https://github.com/apache/tomee/pull/2902#issuecomment-5398860715

   https://github.com/jgallimore/tomee/pull/12/changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TOMEE-4682 TomEESecurityContext.authenticate() should delegate to Htt… (tomee)

Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 merged PR #2902:
URL: https://github.com/apache/tomee/pull/2902


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TOMEE-4682 TomEESecurityContext.authenticate() should delegate to Htt… (tomee)

Posted by "exabrial (via GitHub)" <gi...@apache.org>.
exabrial commented on PR #2902:
URL: https://github.com/apache/tomee/pull/2902#issuecomment-5398416206

   Hey Jonathan! Excellent patch! I did some local testing and found a couple of areas that are tangentially related:
   
   * `@LoginToContinue` produces sessions 100% of the time, when it should really just produce one when redirecting to login. So if accessing a non-protected resource -> don't create a session. If accessing one -> create a session to save the request
   
   * Speaking of the request; the saved request to be replayed isn't getting fully replayed.
   
   I'll get these pushed to an additional PR in a few mins


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org