You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/08/07 14:34:58 UTC

[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #144: Log incase of missing environment variables

pjfanning commented on code in PR #144:
URL: https://github.com/apache/incubator-pekko-grpc/pull/144#discussion_r1285959313


##########
gradle-plugin/build.gradle:
##########
@@ -51,13 +53,24 @@ publishing {
     }
 }
 
+def getEnvVariable(String value) {

Review Comment:
   to avoid confusion, the input variable could be called 'name' or 'envVariableName'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org