You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Rainer Jung <ra...@kippdata.de> on 2010/07/21 11:18:52 UTC
Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/
java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/
On 21.07.2010 09:40, Mark Thomas wrote:
> On 20/07/2010 11:14, Rainer Jung wrote:
>> So: the default we use is 10000, but if the timeout were<=0 then I
>> think the condition in the AsyncTimeout runnable would fail.
>
> Agreed. That matches with what I was observing.
>
> I have no idea if a default timeout of 10s is appropriate for Async
> requests or not. It seems like a good place to start but I'd be fine
> with 60s too. The advantage of a shorter timeout is that when tests
> fail, they fail relatively quickly.
IMHO for any serious application of async the developer will need to
adjust the timeout. A very long default is of no real use as a timeout,
so I'd be fine with the 10 seconds we have now. Yes, many use cases will
fire the timeout though they want to wait longer, but at least they get
aware they need to adjust.
Once we've finalized this we need to add the asyncTimeout description to
the connectors config docs (though IMHO when people start to use
different async use cases in parallel, a connector configuration will no
longer be enough and they have to set the timeout via the AsyncContext API).
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r965150 - in /tomcat/trunk:
java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/
webapps/docs/ webapps/docs/config/
Posted by Remy Maucherat <re...@apache.org>.
On Wed, 2010-07-21 at 21:36 +0100, Mark Thomas wrote:
> I take it that this means you think there is room for simplification.
> I'm still trying to get my head around the Async implementation so if
> you have any pointers on how it could be simplified, they would be much
> appreciated.
Ok, so for this particular topic, the argument I gave to the expert
group to avoid having to specify a timeout every time was that the
connector timeout was a decent default. This did convince enough people.
I don't see how putting another specific constant is a good idea here.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/
java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/
Posted by Mark Thomas <ma...@apache.org>.
On 21/07/2010 10:47, Remy Maucherat wrote:
> On Wed, 2010-07-21 at 11:18 +0200, Rainer Jung wrote:
>> IMHO for any serious application of async the developer will need to
>> adjust the timeout.
>
> I am responsible for the fact that setting the timeout is separate, as I
> did not understand how it was meaningful in most cases to have it be
> anything other than the usual timeout set by the connector.
>
> I am impressed with the creativity that has been displayed so far on the
> async API implementation in Tomcat 7, so I guess that arbitrary 10s
> value goes along fine with that.
I take it that this means you think there is room for simplification.
I'm still trying to get my head around the Async implementation so if
you have any pointers on how it could be simplified, they would be much
appreciated.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r965150 - in /tomcat/trunk:
java/org/apache/catalina/connector/ java/org/apache/tomcat/util/net/
webapps/docs/ webapps/docs/config/
Posted by Remy Maucherat <re...@apache.org>.
On Wed, 2010-07-21 at 11:18 +0200, Rainer Jung wrote:
> IMHO for any serious application of async the developer will need to
> adjust the timeout.
I am responsible for the fact that setting the timeout is separate, as I
did not understand how it was meaningful in most cases to have it be
anything other than the usual timeout set by the connector.
I am impressed with the creativity that has been displayed so far on the
async API implementation in Tomcat 7, so I guess that arbitrary 10s
value goes along fine with that.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r965150 - in /tomcat/trunk: java/org/apache/catalina/connector/
java/org/apache/tomcat/util/net/ webapps/docs/ webapps/docs/config/
Posted by Mark Thomas <ma...@apache.org>.
On 21/07/2010 10:18, Rainer Jung wrote:
> On 21.07.2010 09:40, Mark Thomas wrote:
>> On 20/07/2010 11:14, Rainer Jung wrote:
>>> So: the default we use is 10000, but if the timeout were<=0 then I
>>> think the condition in the AsyncTimeout runnable would fail.
>>
>> Agreed. That matches with what I was observing.
>>
>> I have no idea if a default timeout of 10s is appropriate for Async
>> requests or not. It seems like a good place to start but I'd be fine
>> with 60s too. The advantage of a shorter timeout is that when tests
>> fail, they fail relatively quickly.
>
> IMHO for any serious application of async the developer will need to
> adjust the timeout. A very long default is of no real use as a timeout,
> so I'd be fine with the 10 seconds we have now. Yes, many use cases will
> fire the timeout though they want to wait longer, but at least they get
> aware they need to adjust.
+1
> Once we've finalized this we need to add the asyncTimeout description to
> the connectors config docs (though IMHO when people start to use
> different async use cases in parallel, a connector configuration will no
> longer be enough and they have to set the timeout via the AsyncContext
> API).
The docs were updated when I added the configuration option. Note that
only HTTP BIO has an implementation at the moment. Once I have a fix for
bug 49567 that passes the TCK then I'll extend the fix to cover the
other connectors.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org