You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/25 14:08:40 UTC

[GitHub] [airflow] mik-laj opened a new pull request, #27263: Add backward compatibility with old versions of Apache Beam

mik-laj opened a new pull request, #27263:
URL: https://github.com/apache/airflow/pull/27263

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   The PR https://github.com/apache/airflow/pull/23961
   added support for impersonation of service accounts, but at the same time limited the supported versions of Apache Beam to 2.39.0.  This is a very big limitation considering that this functionality is not critical and many existing pipelines require an older version.  On the other hand, this restriction is not checked if the user installs beam in a separate virtual environment. On the other hand, this restriction is not checked if the user installs beam in a separate virtual environment. Then Apache Beam starts, but unsupported options are passed.
   
   To solve these two problems, I moved the Apache Beam version check to runtime and use the old version restrictions in `providers.yaml`.
   
   Additionally, I will unblock the work on Snowpark integration which requires `cloudpickle` 2.0.0 while Apache Beam 2.39.0 requires `cloudpickle` 2.1.0.
   
   
   CC: @lwyszomi  
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #27263: Add backward compatibility with old versions of Apache Beam

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27263:
URL: https://github.com/apache/airflow/pull/27263#issuecomment-1304989807

   Rebased-  I have fixed the "backtracking" issue in main (some newly released dependencies caused back-tracking of pip resolver),  so it should not fail this time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #27263: Add backward compatibility with old versions of Apache Beam

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27263:
URL: https://github.com/apache/airflow/pull/27263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #27263: Add backward compatibility with old versions of Apache Beam

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27263:
URL: https://github.com/apache/airflow/pull/27263#issuecomment-1296542687

   Tests failing though


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] lwyszomi commented on pull request #27263: Add backward compatibility with old versions of Apache Beam

Posted by GitBox <gi...@apache.org>.
lwyszomi commented on PR #27263:
URL: https://github.com/apache/airflow/pull/27263#issuecomment-1294505012

   @mik-laj LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org