You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "majialoong (via GitHub)" <gi...@apache.org> on 2026/09/10 17:25:42 UTC
[PR] KAFKA-21019: Add consumer and share group protocol test cases to Docker sanity tests [kafka]
majialoong opened a new pull request, #23427:
URL: https://github.com/apache/kafka/pull/23427
Add consumer and share group protocol test cases to Docker sanity tests for JVM and native images in both combined and isolated modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-21019: Add consumer and share group protocol test cases to Docker sanity tests [kafka]
Posted by "majialoong (via GitHub)" <gi...@apache.org>.
majialoong commented on code in PR #23427:
URL: https://github.com/apache/kafka/pull/23427#discussion_r3981810736
##########
docker/test/docker_sanity_test.py:
##########
Review Comment:
I noticed that the assertion after `fetching metrics_after_message` seems to need `self.assertEqual(len(metrics_after_message), 2)` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-21019: Add consumer and share group protocol test cases to Docker sanity tests [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23427:
URL: https://github.com/apache/kafka/pull/23427#discussion_r4252437556
##########
docker/test/docker_sanity_test.py:
##########
Review Comment:
yes, you are right! Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-21019: Add consumer and share group protocol test cases to Docker sanity tests [kafka]
Posted by "majialoong (via GitHub)" <gi...@apache.org>.
majialoong commented on PR #23427:
URL: https://github.com/apache/kafka/pull/23427#issuecomment-5764353120
Fixed the metrics length assertion to check `metrics_after_message`.
Local test results:
1. jvm image type
```
python3 ./docker/docker_build_test.py kafka-21019-test --image-tag jvm --image-type jvm --kafka-archive "$KAFKA_TEST_ARCHIVE"
```
<img width="1902" height="873" alt="image" src="https://github.com/user-attachments/assets/d1f3b45f-0f05-44f7-abac-bcc986ab8ca0" />
2. native image type
```
python3 ./docker/docker_build_test.py kafka-21019-test --image-tag native --image-type native --kafka-archive "$KAFKA_TEST_ARCHIVE"
```
<img width="1906" height="851" alt="image" src="https://github.com/user-attachments/assets/cfe13fef-a07b-47de-bddf-2468181a4798" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-21019: Add consumer and share group protocol test cases to Docker sanity tests [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #23427:
URL: https://github.com/apache/kafka/pull/23427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-21019: Add consumer and share group protocol test cases to Docker sanity tests [kafka]
Posted by "majialoong (via GitHub)" <gi...@apache.org>.
majialoong commented on PR #23427:
URL: https://github.com/apache/kafka/pull/23427#issuecomment-5622765063
Local tests passed:
1. jvm image type
```
python3 ./docker/docker_build_test.py kafka-21019-test --image-tag jvm --image-type jvm --kafka-archive "$KAFKA_TEST_ARCHIVE"
```
<img width="1899" height="867" alt="image" src="https://github.com/user-attachments/assets/136c43ee-df0e-40fd-b47c-643a9d756231" />
2. native image type
```
python3 ./docker/docker_build_test.py kafka-21019-test --image-tag native --image-type native --kafka-archive "$KAFKA_TEST_ARCHIVE"
```
<img width="1900" height="834" alt="image" src="https://github.com/user-attachments/assets/1c82b2db-b269-47b4-86a4-5fa149c25571" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org