You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/04/04 16:43:38 UTC

[GitHub] [parquet-format] emkornfield commented on a change in pull request #169: PARQUET-2013: [Format] Mention that ConvertedType is deprecated

emkornfield commented on a change in pull request #169:
URL: https://github.com/apache/parquet-format/pull/169#discussion_r606825680



##########
File path: src/main/thrift/parquet.thrift
##########
@@ -316,7 +317,7 @@ struct BsonType {
  * LogicalType annotations to replace ConvertedType.
  *
  * To maintain compatibility, implementations using LogicalType for a
- * SchemaElement must also set the corresponding ConvertedType from the
+ * SchemaElement should also set the corresponding ConvertedType from the

Review comment:
       sorry for the belated comment by why the change from must to should?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org