You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2021/09/24 18:41:28 UTC

[tomcat] branch main updated: Use base 16 rather than base 10 for IDs. Marginally faster and no -ve

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
     new 0608beb  Use base 16 rather than base 10 for IDs. Marginally faster and no -ve
0608beb is described below

commit 0608beb7fa910b67d2833a197539048222c76d45
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Sep 24 19:41:21 2021 +0100

    Use base 16 rather than base 10 for IDs. Marginally faster and no -ve
---
 java/org/apache/coyote/Request.java                    | 2 +-
 java/org/apache/tomcat/util/net/SocketWrapperBase.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/java/org/apache/coyote/Request.java b/java/org/apache/coyote/Request.java
index 2bbabaf..d9d0732 100644
--- a/java/org/apache/coyote/Request.java
+++ b/java/org/apache/coyote/Request.java
@@ -793,7 +793,7 @@ public final class Request {
         available = 0;
         sendfile = true;
 
-        requestId = Long.toString(requestIdGenerator.getAndIncrement());
+        requestId = Long.toHexString(requestIdGenerator.getAndIncrement());
 
         serverCookies.recycle();
         parameters.recycle();
diff --git a/java/org/apache/tomcat/util/net/SocketWrapperBase.java b/java/org/apache/tomcat/util/net/SocketWrapperBase.java
index 4b26219..2ab32ef 100644
--- a/java/org/apache/tomcat/util/net/SocketWrapperBase.java
+++ b/java/org/apache/tomcat/util/net/SocketWrapperBase.java
@@ -137,7 +137,7 @@ public abstract class SocketWrapperBase<E> {
             readPending = null;
             writePending = null;
         }
-        connectionId = Long.toString(connectionIdGenerator.getAndIncrement());
+        connectionId = Long.toHexString(connectionIdGenerator.getAndIncrement());
     }
 
     public E getSocket() {

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org