You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/03/23 18:53:36 UTC
[GitHub] [hadoop] xkrogen commented on issue #1889: HDFS-15215 The Timestamp
for longest write/read lock held log is wrong
xkrogen commented on issue #1889: HDFS-15215 The Timestamp for longest write/read lock held log is wrong
URL: https://github.com/apache/hadoop/pull/1889#issuecomment-602791236
Hey folks, apologies for the late response. I'm just getting back from vacation.
The change looks good to me. Good catch @brfrn169 . I agree with your `FakeTimer` change, it seems that separating the `now()` and `monotonicNow()` will help catch such issues in the future. I've made this same mistake in another place and didn't catch it because the `FakeTimer` treats them the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org