[GitHub] [trafficserver] cybertunnel commented on a diff in pull request #9960: Adding host URL to NextHop Strategies debug message during host mark down.

["cybertunnel (via GitHub)" <gi...@apache.org>]

cybertunnel commented on code in PR #9960:
URL: https://github.com/apache/trafficserver/pull/9960#discussion_r1258842062


##########
proxy/http/remap/NextHopHealthStatus.cc:
##########
@@ -76,6 +76,7 @@ NextHopHealthStatus::markNextHop(TSHttpTxn txn, const char *hostname, const int
   int64_t fail_threshold  = sm->t_state.txn_conf->parent_fail_threshold;
   int64_t retry_time      = sm->t_state.txn_conf->parent_retry_time;
   uint32_t new_fail_count = 0;
+  const char *host        = sm->t_state.request_data.get_host();

Review Comment:
   If I understand asserts in c++ properly, this would essentially kill ATS if the host is null, right? Do we really want to kill the entire ATS program if there is a single malformed URL host being sent?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org