You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2008/09/16 06:27:44 UTC

[jira] Created: (HADOOP-4181) some minor things to make Hadoop friendlier to git

some minor things to make Hadoop friendlier to git
--------------------------------------------------

                 Key: HADOOP-4181
                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
             Project: Hadoop Core
          Issue Type: Improvement
          Components: build
            Reporter: Owen O'Malley
         Attachments: git.patch

It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4181:
----------------------------------

    Attachment: git.patch

Added some more patterns.

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: git.patch, git.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Enis Soztutar updated HADOOP-4181:
----------------------------------

    Attachment: git4.patch

Ok, .svn w/o wildcards work. However, my git repository still shows build/ directory in git status. I checked the git documentation, and it says that patterns ending with / matches only the directory names via glob/fnmatch. 
The attached patch adds .svn, and removes trailing /'s. Although the pattern will prevent files with name "build", I think we can live with that. 



> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: .gitignore, git.patch, git.patch, git.patch, git2.patch, git3.patch, git4.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Enis Soztutar reopened HADOOP-4181:
-----------------------------------


Reopening this issue, to add 
*.svn*
to .gitignore. We better not track svn files with git. 

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: git.patch, git.patch, git.patch, git2.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4181:
----------------------------------

    Fix Version/s: 0.19.0

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: git.patch, git.patch, git.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4181:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed the git3.patch.

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: .gitignore, git.patch, git.patch, git.patch, git2.patch, git3.patch, git4.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4181:
----------------------------------

    Status: Patch Available  (was: Reopened)

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: .gitignore, git.patch, git.patch, git.patch, git2.patch, git3.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631461#action_12631461 ] 

Doug Cutting commented on HADOOP-4181:
--------------------------------------

The ignored files should match those for subversion, no?  It would be nice to have a way to automatically set git's to subversion's, so that we don't have to maintain this in two places.  I note that the version in the patch is missing logs, .classpath, .project, .settings, src/docs/build, lib/excluded, etc.


> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: git.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4181:
----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this.

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: git.patch, git.patch, git.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Enis Soztutar updated HADOOP-4181:
----------------------------------

    Attachment: .gitignore

Attaching patch

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: .gitignore, git.patch, git.patch, git.patch, git2.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4181:
----------------------------------

    Attachment: git.patch

Removed prefix and included .gitignore

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: git.patch, git.patch, git.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Chris K Wensel (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631630#action_12631630 ] 

Chris K Wensel commented on HADOOP-4181:
----------------------------------------

git doesn't like abbreviations..

thus:
> git br 
won't work out of the box

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: git.patch, git.patch, git.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Chris K Wensel (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631644#action_12631644 ] 

Chris K Wensel commented on HADOOP-4181:
----------------------------------------

+1 works great

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: git.patch, git.patch, git.patch, git2.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4181:
----------------------------------

    Assignee: Owen O'Malley

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: git.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631639#action_12631639 ] 

Owen O'Malley commented on HADOOP-4181:
---------------------------------------

*Darn it* Of course it works in my case, because I have it set it my global git configuration.

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: git.patch, git.patch, git.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631574#action_12631574 ] 

Doug Cutting commented on HADOOP-4181:
--------------------------------------

+1 This looks fine.

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: git.patch, git.patch, git.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4181:
----------------------------------

    Attachment: git3.patch

Enis, How does this look? I just add the .svn without wildcards or slashes. It seems to do the right thing.

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: .gitignore, git.patch, git.patch, git.patch, git2.patch, git3.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633295#action_12633295 ] 

Hudson commented on HADOOP-4181:
--------------------------------

Integrated in Hadoop-trunk #611 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/611/])

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: .gitignore, git.patch, git.patch, git.patch, git2.patch, git3.patch, git4.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4181:
----------------------------------

    Attachment: git.patch

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>         Attachments: git.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4181:
----------------------------------

    Status: Patch Available  (was: Open)

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: git.patch, git.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632323#action_12632323 ] 

Owen O'Malley commented on HADOOP-4181:
---------------------------------------

Are you using an old version of git?

>From http://www.kernel.org/pub/software/scm/git/docs/gitignore.html:

{quote}
If the pattern ends with a slash, it is removed for the purpose of the following description, but it would only find a match with a directory. In other words, foo/ will match a directory foo and paths underneath it, but will not match a regular file or a symbolic link foo (this is consistent with the way how pathspec works in general in git). 
{quote}

So my version will not ignore a build script that someone adds, or build directories somewhere else in the directory tree. I think being more precise is a good thing when we are specifying things to be ignored by scm.

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: .gitignore, git.patch, git.patch, git.patch, git2.patch, git3.patch, git4.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4181:
----------------------------------

    Attachment: git2.patch

Here is the trivial fix. Chris W., can you check it out for me?

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: git.patch, git.patch, git.patch, git2.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4181) some minor things to make Hadoop friendlier to git

Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632554#action_12632554 ] 

Enis Soztutar commented on HADOOP-4181:
---------------------------------------

What are the chances that I am using git-1.5.2, and the issue seems to be fixed at 1.5.5 ! I guess it is time for me to dist-upgrade :)

>From git-1.5.5 release notes : http://www.kernel.org/pub/software/scm/git/docs/RelNotes-1.5.5.txt 
{quote} * A pattern "foo/" in .gitignore file now matches a directory
      "foo".  Pattern "foo" also matches as before.
{quote}

+1 for git3.patch. 

> some minor things to make Hadoop friendlier to git
> --------------------------------------------------
>
>                 Key: HADOOP-4181
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4181
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: .gitignore, git.patch, git.patch, git.patch, git2.patch, git3.patch, git4.patch
>
>
> It would be nice to have a .gitignore file and a saveVersion that didn't fail under git.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.