You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "OyvindLGjesdal (via GitHub)" <gi...@apache.org> on 2026/03/02 14:15:40 UTC
[PR] Investitage es-lint upgrade [jena]
OyvindLGjesdal opened a new pull request, #3778:
URL: https://github.com/apache/jena/pull/3778
GitHub issue resolved #
Pull request Description:
Dependabot fails build for eslint. Investigating why.
If eslint also has an updated version and updated lockfile, the CI runs successfully.
However there are some other issues/warnings, that should probably be updated with the new version.
lockfile updated with
````
yarn update eslint@10.0.1
```
```
warning " > @vue/eslint-config-standard@8.0.1" has incorrect peer dependency "eslint@^8.0.1".
warning "@vue/eslint-config-standard > eslint-config-standard@17.1.0" has incorrect peer dependency "eslint@^8.0.1".
warning " > eslint-plugin-import@2.32.0" has incorrect peer dependency "eslint@^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8 || ^9".
warning "@vue/eslint-config-standard > eslint-plugin-promise@6.6.0" has incorrect peer dependency "eslint@^7.0.0 || ^8.0.0 || ^9.0.0".
warning " > eslint-plugin-promise@7.2.1" has incorrect peer dependency "eslint@^7.0.0 || ^8.0.0 || ^9.0.0".
warning " > eslint-plugin-vue@9.33.0" has incorrect peer dependency "eslint@^6.2.0 || ^7.0.0 || ^8.0.0 || ^9.0.0".
```
eslint-plugin-standard no longer in use: https://www.npmjs.com/package/eslint-plugin-standard (can probably just remove)
Will try to update also rest of dependencies.
----
- [ ] Tests are included.
- [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/)
- [ ] Commits have been squashed to remove intermediate development commit messages.
- [ ] Key commit messages start with the issue number (GH-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] Investitage es-lint upgrade [jena]
Posted by "OyvindLGjesdal (via GitHub)" <gi...@apache.org>.
OyvindLGjesdal commented on PR #3778:
URL: https://github.com/apache/jena/pull/3778#issuecomment-3986930113
This should be ready for review. Would you have the time to check if the javascript specific changes looks ok @kinow?
I'm not that confident in the jena-ui. Fixed the new eslint errors by adding browser to globals.
Some things could have a followup (or removing dependencies?) if my assumptions are correct that some eslint config files aren't read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] Investitage es-lint upgrade [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #3778:
URL: https://github.com/apache/jena/pull/3778#issuecomment-3985592398
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] Upgrade es-lint and dependencies [jena]
Posted by "OyvindLGjesdal (via GitHub)" <gi...@apache.org>.
OyvindLGjesdal merged PR #3778:
URL: https://github.com/apache/jena/pull/3778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] Upgrade es-lint and dependencies [jena]
Posted by "OyvindLGjesdal (via GitHub)" <gi...@apache.org>.
OyvindLGjesdal commented on PR #3778:
URL: https://github.com/apache/jena/pull/3778#issuecomment-4022772916
This should be ready for merging to solve/close https://github.com/apache/jena/pull/3748 where build fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] Upgrade es-lint and dependencies [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #3778:
URL: https://github.com/apache/jena/pull/3778#issuecomment-4023147661
Hi @OyvindLGjesdal - looks good.
Would you care to merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] Investitage es-lint upgrade [jena]
Posted by "OyvindLGjesdal (via GitHub)" <gi...@apache.org>.
OyvindLGjesdal commented on PR #3778:
URL: https://github.com/apache/jena/pull/3778#issuecomment-3986140373
Three depencies are not updated for 10 yet and gives warnings:
```
eslint-config-standard@9.0.1" has incorrect peer dependency "eslint@^9.10.0".
warning "@vue/eslint-config-standard > eslint-plugin-import-x@4.16.1" has incorrect peer dependency "eslint@^8.57.0 || ^9.0.0".
warning " > eslint-plugin-promise@7.2.1" has incorrect peer dependency "eslint@^7.0.0 || ^8.0.0 || ^9.0.0".
warning " > eslint-plugin-import
```
After update there are also some new lint errors:
```
$ eslint --fix src
/Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/components/ServerStatus.vue
66:21 error 'setInterval' is not defined no-undef
72:5 error 'clearInterval' is not defined no-undef
/Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/components/Toast.vue
120:7 error 'setTimeout' is not defined no-undef
/Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/plugins/services.js
26:67 error 'window' is not defined no-undef
/Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/services/fuseki.service.js
147:13 error There is no `cause` attached to the symptom error being thrown preserve-caught-error
149:11 error There is no `cause` attached to the symptom error being thrown preserve-caught-error
/Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/services/mock/json-server.js
290:7 error 'console' is not defined no-undef
299:3 error 'console' is not defined no-undef
/Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/utils/query.js
43:5 error 'document' is not defined no-undef
45:5 error 'document' is not defined no-undef
46:5 error 'document' is not defined no-undef
47:5 error 'document' is not defined no-undef
/Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/utils/validation.js
42:9 error 'URL' is not defined no-undef
/Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/views/dataset/Edit.vue
245:9 error 'alert' is not defined no-undef
/Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/views/dataset/Query.vue
274:7 error 'setTimeout' is not defined no-undef
277:9 error 'document' is not defined no-undef
278:9 error 'document' is not defined no-undef
282:11 error 'document' is not defined no-undef
299:11 error 'document' is not defined no-undef
/Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/views/manage/Tasks.vue
117:20 error 'setInterval' is not defined no-undef
130:7 error 'clearInterval' is not defined no-undef
```
Since jena has implemented/moved into the flat config file described in https://eslint.org/docs/latest/use/configure/migration-guide I think the old style rc files are not read. Therefore I think these are currently not used/picked up:
```
./tests/.eslintrc.js
./tests/e2e/.eslintrc.js
```
and have to be migrated to the flat format (`eslint.config.js` in `jena-fuseki-ui`).
However the ci job that runs lint also just uses `eslint --fix src` so I think that means the linting for tests has mostly been done on the developer machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] Investigate es-lint upgrade [jena]
Posted by "OyvindLGjesdal (via GitHub)" <gi...@apache.org>.
OyvindLGjesdal commented on PR #3778:
URL: https://github.com/apache/jena/pull/3778#issuecomment-4020041470
Thanks for reviewing @kinow,. I am just reverting the ecma-version change, which I think was not relevant for the build passing, to not add uneccesary changes (was suggested by LLM to fix warnings in IntelliJ, IDE but didn't change anything)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] Investigate es-lint upgrade [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #3778:
URL: https://github.com/apache/jena/pull/3778#issuecomment-3997943415
I pulled the PR, didn't rebase to latest main (see conflict), did a build and ran the server.
From an incognito window, I uploaded data (first attempt - got an error wanting a graph name of blank when it was blank - IIRC this is not new; second time upload worked), and did a query.
It worked 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org