You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/09 05:13:12 UTC
[GitHub] [zookeeper] tisonkun opened a new pull request, #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request
tisonkun opened a new pull request, #1904:
URL: https://github.com/apache/zookeeper/pull/1904
This patch is based on #1903.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request
Posted by GitBox <gi...@apache.org>.
symat commented on PR #1904:
URL: https://github.com/apache/zookeeper/pull/1904#issuecomment-1181620812
> I changed the description of this patch to close https://github.com/apache/zookeeper/pull/1903 and you can help merge this. I'm not a committer of ZK and thus don't have the privilege to perform the action though :)
sorry, my bad :)
I'll close 1903 and merge this one now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] sonatype-lift[bot] commented on a diff in pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on code in PR #1904:
URL: https://github.com/apache/zookeeper/pull/1904#discussion_r917224173
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java:
##########
@@ -1405,31 +1401,31 @@ public void processConnectRequest(ServerCnxn cnxn, ByteBuffer incomingBuffer)
Review Comment:
*THREAD_SAFETY_VIOLATION:* Read/Write race. Non-private method `ZooKeeperServer.processConnectRequest(...)` reads without synchronization from `this.localSessionEnabled`. Potentially races with write in method `ZooKeeperServer.startupWithoutServing()`.
Reporting because another access to the same memory occurs on a background thread, although this access may not.
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=294718307&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=294718307&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=294718307&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=294718307&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=294718307&lift_comment_rating=5) ]
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java:
##########
@@ -1405,31 +1401,31 @@ public void processConnectRequest(ServerCnxn cnxn, ByteBuffer incomingBuffer)
ServerMetrics.getMetrics().CONNECTION_TOKEN_DEFICIT.add(connThrottle.getDeficit());
ServerMetrics.getMetrics().CONNECTION_REQUEST_COUNT.add(1);
- if (cnxn.protocolManager.isReadonlyAvailable()) {
+ if (!cnxn.protocolManager.isReadonlyAvailable()) {
LOG.warn(
"Connection request from old client {}; will be dropped if server is in r-o mode",
cnxn.getRemoteSocketAddress());
}
- if (!connReq.getReadOnly() && this instanceof ReadOnlyZooKeeperServer) {
+ if (!request.getReadOnly() && this instanceof ReadOnlyZooKeeperServer) {
String msg = "Refusing session request for not-read-only client " + cnxn.getRemoteSocketAddress();
LOG.info(msg);
throw new CloseRequestException(msg, ServerCnxn.DisconnectReason.NOT_READ_ONLY_CLIENT);
}
- if (connReq.getLastZxidSeen() > zkDb.dataTree.lastProcessedZxid) {
+ if (request.getLastZxidSeen() > zkDb.dataTree.lastProcessedZxid) {
Review Comment:
*THREAD_SAFETY_VIOLATION:* Read/Write race. Non-private method `ZooKeeperServer.processConnectRequest(...)` reads without synchronization from `this.zkDb.dataTree`. Potentially races with write in method `ZooKeeperServer.shutdown(...)`.
Reporting because another access to the same memory occurs on a background thread, although this access may not.
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=294718367&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=294718367&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=294718367&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=294718367&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=294718367&lift_comment_rating=5) ]
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java:
##########
@@ -427,11 +428,13 @@ public void enableRecv() {
}
}
- private void readConnectRequest() throws IOException, InterruptedException, ClientCnxnLimitException {
+ private void readConnectRequest() throws IOException, ClientCnxnLimitException {
if (!isZKServerRunning()) {
throw new IOException("ZooKeeperServer not running");
}
- zkServer.processConnectRequest(this, incomingBuffer);
+ BinaryInputArchive bia = BinaryInputArchive.getArchive(new ByteBufferInputStream(incomingBuffer));
Review Comment:
*RESOURCE_LEAK:* resource of type `org.apache.zookeeper.server.ByteBufferInputStream` acquired by call to `new()` at line 435 is not released after line 435.
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=294718778&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=294718778&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=294718778&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=294718778&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=294718778&lift_comment_rating=5) ]
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java:
##########
@@ -427,11 +428,13 @@ public void enableRecv() {
}
}
- private void readConnectRequest() throws IOException, InterruptedException, ClientCnxnLimitException {
+ private void readConnectRequest() throws IOException, ClientCnxnLimitException {
if (!isZKServerRunning()) {
throw new IOException("ZooKeeperServer not running");
}
- zkServer.processConnectRequest(this, incomingBuffer);
+ BinaryInputArchive bia = BinaryInputArchive.getArchive(new ByteBufferInputStream(incomingBuffer));
+ ConnectRequest request = protocolManager.deserializeConnectRequest(bia);
Review Comment:
*RESOURCE_LEAK:* resource of type `java.io.DataInputStream` acquired by call to `getArchive(...)` at line 435 is not released after line 436.
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=294718881&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=294718881&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=294718881&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=294718881&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=294718881&lift_comment_rating=5) ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #1904:
URL: https://github.com/apache/zookeeper/pull/1904#issuecomment-1181625219
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request
URL: https://github.com/apache/zookeeper/pull/1904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #1904:
URL: https://github.com/apache/zookeeper/pull/1904#issuecomment-1181612439
@symat I agree we can merge this patch and close #1903 , later review two related JIRA tickets.
I changed the description of this patch to close #1903 and you can help merge this. I'm not a committer of ZK and thus don't have the privilege to perform the action though :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] tisonkun commented on a diff in pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #1904:
URL: https://github.com/apache/zookeeper/pull/1904#discussion_r917225082
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java:
##########
@@ -78,7 +79,29 @@ public Request(long sessionId, int xid, int type, TxnHeader hdr, Record txn, lon
public final int type;
- public final ByteBuffer request;
+ private final ByteBuffer request;
Review Comment:
This field will later be encapsulated in a `RequestSupplier` similar to @Randgalt done for `RequestPacker` here https://github.com/Randgalt/zookeeper/compare/wip-jute-rpc-generate...wip-jute-rpc-encapsulate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org