You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/11/04 16:51:08 UTC
[GitHub] incubator-brooklyn pull request: show catalogItemId on entities in...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/298
show catalogItemId on entities in jsgui
clickable to go to the catalog item.
currently sometimes this is the alphanumeric ID, but that will change with revision to #92 (the code here is doing the right thing in retrieving the `catalogItemId` from `Entity`)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn catalog-in-jsgui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #298
----
commit b263ceae1ede69280a6448440f3acc6f81566618
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-11-04T15:21:56Z
tweak blueprint, should use metric not binary suffixes (binary 100g doesn't match in some clouds, eg softlayer)
commit 6a25406cdc62f45486d35a0d6efe863cb878120c
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-11-04T15:23:07Z
catalog in jsgui wip
commit 4dede79291515a4e6acfb676e38b75bb0558849f
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-11-04T15:32:18Z
include catalogItemId in REST API and show in the summary on the GUI when available on an entity, and better spacing and suppressing of absent/redundant information in entity-summary page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: show catalogItemId on entities in...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: show catalogItemId on entities in...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/298#issuecomment-61780389
Good to merge, working as expected in local tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: show catalogItemId on entities in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: show catalogItemId on entities in...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/298#issuecomment-61685062
should be fixed now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: show catalogItemId on entities in...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/298#issuecomment-61669664
jenkins failure is rat for `usage/camp/src/test/resources/vanilla-bash-netcat-restarter.yaml`, which is missing header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: show catalogItemId on entities in...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/298#issuecomment-61727294
have never seen this failure -- `brooklyn.entity.webapp.DynamicWebAppClusterTest.testTestJavaWebAppEntityStarts` -- perhaps unrealted. closing and reopening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: show catalogItemId on entities in...
Posted by ahgittin <gi...@git.apache.org>.
GitHub user ahgittin reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/298
show catalogItemId on entities in jsgui
clickable to go to the catalog item.
currently sometimes this is the alphanumeric ID, but that will change with revision to #92 (the code here is doing the right thing in retrieving the `catalogItemId` from `Entity`)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn catalog-in-jsgui
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #298
----
commit e9c8c5efbfb3d862e776931a96b8b7e0a1847196
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-11-04T17:59:20Z
catalog item id in GUI (clickable) and on REST
in REST API for EntitySummary and PolicySummary,
and in summary tab on GUI when available;
also better spacing and suppressing of absent/redundant information in entity-summary page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: show catalogItemId on entities in...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/298#issuecomment-61780242
Regarding the `brooklyn.entity.webapp.DynamicWebAppClusterTest.testTestJavaWebAppEntityStarts ` failure, it's unrelated because master is failing as well.
https://builds.apache.org/job/incubator-brooklyn-master-windows/49/testReport/
(the windows build really brings out all those non-deterministic tests)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---