[GitHub] ivankelly closed pull request #1060: [Merge Yahoo repo]: Flush after writing out index

[GitBox <gi...@apache.org>]

ivankelly closed pull request #1060: [Merge Yahoo repo]: Flush after writing out index
URL: https://github.com/apache/bookkeeper/pull/1060
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
index 4eab466d4..c3039b5f8 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
@@ -568,6 +568,9 @@ public void accept(long ledgerId, long size) {
         } finally {
             serializedMap.release();
         }
+        // Flush the ledger's map out before we write the header.
+        // Otherwise the header might point to something that is not fully written
+        entryLogChannel.flush(false);
 
         // Update the headers with the map offset and count of ledgers
         ByteBuffer mapInfo = ByteBuffer.allocate(8 + 4);


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services