[buildstream] 05/10: _artifactcache.py: Fix misleading log message when pulling artifacts

[no...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

not-in-ldap pushed a commit to branch juerg/public-data
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit e8e77415094b4a69cab3afe406c56b9202638c6a
Author: Jürg Billeter <j...@bitron.ch>
AuthorDate: Mon Mar 30 13:17:16 2020 +0200

    _artifactcache.py: Fix misleading log message when pulling artifacts
    
    Do not print message "Pulled artifact" when pulling the artifact proto
    without data. This matches the log messages in `SourceCache`.
---
 src/buildstream/_artifactcache.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/buildstream/_artifactcache.py b/src/buildstream/_artifactcache.py
index f1648e9..4290e92 100644
--- a/src/buildstream/_artifactcache.py
+++ b/src/buildstream/_artifactcache.py
@@ -281,7 +281,6 @@ class ArtifactCache(BaseCache):
                 element.status("Pulling artifact {} <- {}".format(display_key, remote))
                 artifact = self._pull_artifact_proto(element, key, remote)
                 if artifact:
-                    element.info("Pulled artifact {} <- {}".format(display_key, remote))
                     break
 
                 element.info("Remote ({}) does not have artifact {} cached".format(remote, display_key))
@@ -307,7 +306,7 @@ class ArtifactCache(BaseCache):
                 element.status("Pulling data for artifact {} <- {}".format(display_key, remote))
 
                 if self._pull_artifact_storage(element, artifact, remote, pull_buildtrees=pull_buildtrees):
-                    element.info("Pulled data for artifact {} <- {}".format(display_key, remote))
+                    element.info("Pulled artifact {} <- {}".format(display_key, remote))
                     return True
 
                 element.info("Remote ({}) does not have artifact {} cached".format(remote, display_key))