You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/02 06:03:03 UTC

[GitHub] [fineract] ptuomola opened a new pull request #1136: FINERACT-1016: Fixing rounding issues in integration tests

ptuomola opened a new pull request #1136:
URL: https://github.com/apache/fineract/pull/1136


   ## Description
   Fixes the rounding issues when comparing expected interest with actual interest by allowing 1 unit tolerance between the two
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1136: FINERACT-1016: Fixing rounding issues in integration tests

Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1136:
URL: https://github.com/apache/fineract/pull/1136#issuecomment-652886286


   Ok - this fixes the rounding error that is causing all the integration tests to fail. 
   
   As @vorburger is on holiday, who could review and merge this? @xurror can you do this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #1136: FINERACT-1016: Fixing rounding issues in integration tests

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1136:
URL: https://github.com/apache/fineract/pull/1136#issuecomment-652916154


   > As @vorburger is on holiday, who could review and merge this? @xurror can you do this?
   
   From day after tomorrow... ;-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger merged pull request #1136: FINERACT-1016: Fixing rounding issues in integration tests

Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1136:
URL: https://github.com/apache/fineract/pull/1136


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org