[GitHub] [accumulo] dlmarion commented on a diff in pull request #3067: Reduce logging when external compactions are cancelled

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #3067:
URL: https://github.com/apache/accumulo/pull/3067#discussion_r1018234392


##########
server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java:
##########
@@ -280,7 +283,13 @@ public CompactionStats call() throws IOException, CompactionCanceledException {
           }
         }
       } catch (IOException | RuntimeException e) {
-        log.warn("{}", e.getMessage(), e);
+        // If compaction was cancelled then this may happen due to an
+        // InterruptedException etc so suppress logging
+        if (!env.isCompactionEnabled()) {

Review Comment:
   I think you have this backward.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org