You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/29 13:41:42 UTC

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #5369: cdcacm:support returning c_cflag & speed via termios

davids5 commented on a change in pull request #5369:
URL: https://github.com/apache/incubator-nuttx/pull/5369#discussion_r795053787



##########
File path: drivers/usbdev/cdcacm.c
##########
@@ -2342,7 +2342,11 @@ static int cdcuart_ioctl(FAR struct file *filep, int cmd, unsigned long arg)
         termiosp->c_iflag = serdev->tc_iflag;
         termiosp->c_oflag = serdev->tc_oflag;
         termiosp->c_lflag = serdev->tc_lflag;
-        termiosp->c_cflag = CS8;
+        termiosp->c_cflag =
+            ((priv->linecoding.parity != CDC_PARITY_NONE) ? PARENB : 0) |

Review comment:
       @xiaoxiang781216 Is it the double negative you do not like? 
   PARENB is enable.  With your suggestion, would it be enabled on Odd parity? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org