[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2314: BP-38: Publish Bookie Service Info on Metadata Service

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #2314:
URL: https://github.com/apache/bookkeeper/pull/2314#discussion_r428095296



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/RegistrationClient.java
##########
@@ -65,6 +67,19 @@
      */
     CompletableFuture<Versioned<Set<BookieSocketAddress>>> getReadOnlyBookies();
 
+    /**
+     * Get detailed information about the services exposed by a Bookie.
+     * For old bookies it is expected to return an empty BookieServiceInfo structure.
+     *
+     * @param bookieId this is the id of the bookie, it can be computed from a {@link BookieSocketAddress}
+     * @return a future represents the available information.
+     *
+     * @since 4.11
+     */
+    default CompletableFuture<Versioned<BookieServiceInfo>> getBookieServiceInfo(String bookieId) {
+        return FutureUtils.value(new Versioned<>(BookieServiceInfo.EMPTY, new LongVersion(-1)));

Review comment:
       BookieServiceInfoUtils.buildLegacyBookieServiceInfo(bookieId)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org