You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@manifoldcf.apache.org by "Erlend Garåsen (Created JIRA)" <ji...@apache.org> on 2012/03/26 16:58:27 UTC
[jira] [Created] (CONNECTORS-435) Replace incorrect
Messages.getString() calls in the main UI with correct ones.
Replace incorrect Messages.getString() calls in the main UI with correct ones.
------------------------------------------------------------------------------
Key: CONNECTORS-435
URL: https://issues.apache.org/jira/browse/CONNECTORS-435
Project: ManifoldCF
Issue Type: Task
Components: Framework core
Affects Versions: ManifoldCF 0.4
Reporter: Erlend Garåsen
Assignee: Erlend Garåsen
Fix For: ManifoldCF 0.6
The Messages.getString() calls in the main UI are incorrect much of the time. They should usually be replaced by one of:
{code}
Messages.getBodyJavascriptString()
Messages.getAttributeJavascriptString()
Messages.getBodyString()
Messages.getAttributeString()
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-435) Replace incorrect
Messages.getString() calls in the main UI with correct ones.
Posted by "Erlend Garåsen (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255524#comment-13255524 ]
Erlend Garåsen commented on CONNECTORS-435:
-------------------------------------------
That makes sense! I'll add the correct HTML entities for these operators, then run the tests once again before I commit my changes. Thanks for your review.
> Replace incorrect Messages.getString() calls in the main UI with correct ones.
> ------------------------------------------------------------------------------
>
> Key: CONNECTORS-435
> URL: https://issues.apache.org/jira/browse/CONNECTORS-435
> Project: ManifoldCF
> Issue Type: Task
> Components: Framework core
> Affects Versions: ManifoldCF 0.4
> Reporter: Erlend Garåsen
> Assignee: Erlend Garåsen
> Fix For: ManifoldCF 0.6
>
> Attachments: CONNECTORS-435.patch
>
>
> The Messages.getString() calls in the main UI are incorrect much of the time. They should usually be replaced by one of:
> {code}
> Messages.getBodyJavascriptString()
> Messages.getAttributeJavascriptString()
> Messages.getBodyString()
> Messages.getAttributeString()
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-435) Replace incorrect
Messages.getString() calls in the main UI with correct ones.
Posted by "Erlend Garåsen (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erlend Garåsen updated CONNECTORS-435:
--------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
r1327112.
> Replace incorrect Messages.getString() calls in the main UI with correct ones.
> ------------------------------------------------------------------------------
>
> Key: CONNECTORS-435
> URL: https://issues.apache.org/jira/browse/CONNECTORS-435
> Project: ManifoldCF
> Issue Type: Task
> Components: Framework core
> Affects Versions: ManifoldCF 0.4
> Reporter: Erlend Garåsen
> Assignee: Erlend Garåsen
> Fix For: ManifoldCF 0.6
>
> Attachments: CONNECTORS-435.patch
>
>
> The Messages.getString() calls in the main UI are incorrect much of the time. They should usually be replaced by one of:
> {code}
> Messages.getBodyJavascriptString()
> Messages.getAttributeJavascriptString()
> Messages.getBodyString()
> Messages.getAttributeString()
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-435) Replace incorrect
Messages.getString() calls in the main UI with correct ones.
Posted by "Erlend Garåsen (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erlend Garåsen updated CONNECTORS-435:
--------------------------------------
Attachment: CONNECTORS-435.patch
Some Message.getString() calls have been replaced in the attached patch.
> Replace incorrect Messages.getString() calls in the main UI with correct ones.
> ------------------------------------------------------------------------------
>
> Key: CONNECTORS-435
> URL: https://issues.apache.org/jira/browse/CONNECTORS-435
> Project: ManifoldCF
> Issue Type: Task
> Components: Framework core
> Affects Versions: ManifoldCF 0.4
> Reporter: Erlend Garåsen
> Assignee: Erlend Garåsen
> Fix For: ManifoldCF 0.6
>
> Attachments: CONNECTORS-435.patch
>
>
> The Messages.getString() calls in the main UI are incorrect much of the time. They should usually be replaced by one of:
> {code}
> Messages.getBodyJavascriptString()
> Messages.getAttributeJavascriptString()
> Messages.getBodyString()
> Messages.getAttributeString()
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-435) Replace incorrect
Messages.getString() calls in the main UI with correct ones.
Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255511#comment-13255511 ]
Karl Wright commented on CONNECTORS-435:
----------------------------------------
Looks generally good, although I didn't check every line. However, I did see one weird thing:
{code}
-" <nobr>"+org.apache.manifoldcf.ui.util.Encoder.bodyEscape(param)+"=<"+Integer.toString(kmanager.getContents().length)+" " + Messages.getString(locale,"DCTM.certificate") + "></nobr><br/>\n"
+" <nobr>"+org.apache.manifoldcf.ui.util.Encoder.bodyEscape(param)+"=<"+Integer.toString(kmanager.getContents().length)+" " + Messages.getAttributeString(locale,"DCTM.certificate") + "></nobr><br/>\n"
{code}
The issue here is that the < and > for the message are not tags. They should in fact be < and >, so that the line should originally read:
{code}
" <nobr>"+org.apache.manifoldcf.ui.util.Encoder.bodyEscape(param)+"=<"+Integer.toString(kmanager.getContents().length)+" " + Messages.getString(locale,"DCTM.certificate") + "></nobr><br/>\n"
{code}
Once that is done it is clear that you need Messages.getBodyString() here, not Messages.getAttributeString().
> Replace incorrect Messages.getString() calls in the main UI with correct ones.
> ------------------------------------------------------------------------------
>
> Key: CONNECTORS-435
> URL: https://issues.apache.org/jira/browse/CONNECTORS-435
> Project: ManifoldCF
> Issue Type: Task
> Components: Framework core
> Affects Versions: ManifoldCF 0.4
> Reporter: Erlend Garåsen
> Assignee: Erlend Garåsen
> Fix For: ManifoldCF 0.6
>
> Attachments: CONNECTORS-435.patch
>
>
> The Messages.getString() calls in the main UI are incorrect much of the time. They should usually be replaced by one of:
> {code}
> Messages.getBodyJavascriptString()
> Messages.getAttributeJavascriptString()
> Messages.getBodyString()
> Messages.getAttributeString()
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-435) Replace incorrect
Messages.getString() calls in the main UI with correct ones.
Posted by "Erlend Garåsen (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erlend Garåsen updated CONNECTORS-435:
--------------------------------------
Status: Patch Available (was: Open)
I ran ant test and run-webcrawler-UI-tests-derby just in case my changes had some side effects. They passed. If there are no comments, I will commit this.
> Replace incorrect Messages.getString() calls in the main UI with correct ones.
> ------------------------------------------------------------------------------
>
> Key: CONNECTORS-435
> URL: https://issues.apache.org/jira/browse/CONNECTORS-435
> Project: ManifoldCF
> Issue Type: Task
> Components: Framework core
> Affects Versions: ManifoldCF 0.4
> Reporter: Erlend Garåsen
> Assignee: Erlend Garåsen
> Fix For: ManifoldCF 0.6
>
> Attachments: CONNECTORS-435.patch
>
>
> The Messages.getString() calls in the main UI are incorrect much of the time. They should usually be replaced by one of:
> {code}
> Messages.getBodyJavascriptString()
> Messages.getAttributeJavascriptString()
> Messages.getBodyString()
> Messages.getAttributeString()
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira