You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/05/11 07:26:20 UTC

[GitHub] [libcloud] ogayot commented on pull request #1690: test/test_http.py: stop HTTP server (thread) properly

ogayot commented on PR #1690:
URL: https://github.com/apache/libcloud/pull/1690#issuecomment-1123283234

   > Added server.socket.close() and merged it into trunk, thanks!
   
   Oh, good catch as well @Kami, thanks!
   Looking back, I think `server.server_close()` was the expected call after `server.shutdown()`.
   
   ```python
   server.shutdown()
   server.server_close()
   ```
   
   But it seems that `server.socket.close()` calls `server.socket.close()` as you did, so I'm sure it's no big deal :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org