You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hust-hhb (via GitHub)" <gi...@apache.org> on 2023/12/22 13:35:42 UTC
[PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
hust-hhb opened a new pull request, #28900:
URL: https://github.com/apache/doris/pull/28900
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1868013438
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.71 seconds
stream load tsv: 566 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17183857547 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1867703984
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1868508804
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1867997587
TeamCity be ut coverage result:
Function Coverage: 36.53% (8539/23374)
Line Coverage: 28.61% (69411/242572)
Region Coverage: 27.64% (35923/129981)
Branch Coverage: 24.37% (18364/75360)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9b2ad8be2b1e8e0fd2394cad87c005c6ead5335e_9b2ad8be2b1e8e0fd2394cad87c005c6ead5335e/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1868508796
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1868006100
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 9b2ad8be2b1e8e0fd2394cad87c005c6ead5335e, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4698 4402 4423 4402
q2 371 142 157 142
q3 1454 1313 1217 1217
q4 1112 922 917 917
q5 3171 3152 3179 3152
q6 246 133 131 131
q7 998 482 486 482
q8 2205 2265 2197 2197
q9 6664 6641 6645 6641
q10 3228 3274 3251 3251
q11 319 185 186 185
q12 364 211 203 203
q13 4553 3843 3777 3777
q14 249 217 216 216
q15 586 524 517 517
q16 442 391 388 388
q17 1016 605 536 536
q18 7061 6784 6757 6757
q19 1542 1472 1459 1459
q20 495 300 326 300
q21 3067 2701 2696 2696
q22 346 275 278 275
Total cold run time: 44187 ms
Total hot run time: 39841 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4356 4326 4405 4326
q2 271 174 168 168
q3 3497 3512 3494 3494
q4 2393 2374 2364 2364
q5 5716 5742 5707 5707
q6 242 125 123 123
q7 2377 1865 1836 1836
q8 3520 3530 3522 3522
q9 9030 9052 8973 8973
q10 3926 4014 4002 4002
q11 485 365 368 365
q12 768 613 592 592
q13 4308 3589 3580 3580
q14 290 267 267 267
q15 572 521 525 521
q16 510 447 492 447
q17 1891 1842 1848 1842
q18 8551 8183 8047 8047
q19 1756 1751 1778 1751
q20 2261 1953 1924 1924
q21 6505 6158 6142 6142
q22 512 421 434 421
Total cold run time: 63737 ms
Total hot run time: 60414 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "hust-hhb (via GitHub)" <gi...@apache.org>.
hust-hhb commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1867697846
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1867913933
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #28900:
URL: https://github.com/apache/doris/pull/28900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1867704745
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "hust-hhb (via GitHub)" <gi...@apache.org>.
hust-hhb commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1867910504
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1867777751
TeamCity be ut coverage result:
Function Coverage: 36.54% (8541/23374)
Line Coverage: 28.63% (69451/242588)
Region Coverage: 27.65% (35937/129981)
Branch Coverage: 24.37% (18367/75358)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a4b3dfdf1d046f428726ce7cae28eaaa308213f7_a4b3dfdf1d046f428726ce7cae28eaaa308213f7/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1867916113
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1867976950
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](group commit) make get column function more reliable when replaying wal [doris]
Posted by "hust-hhb (via GitHub)" <gi...@apache.org>.
hust-hhb commented on PR #28900:
URL: https://github.com/apache/doris/pull/28900#issuecomment-1867967996
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org