You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "wForget (via GitHub)" <gi...@apache.org> on 2026/07/08 07:19:55 UTC

[PR] [#2761] fix(spark): remove unnecessary synchronized [uniffle]

wForget opened a new pull request, #2762:
URL: https://github.com/apache/uniffle/pull/2762

   ### What changes were proposed in this pull request?
   
   Remove unnecessary synchronized for getRemoteShuffleHandleInfo methods
   
   ### Why are the changes needed?
   
   closes #2761
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   (Please list the user-facing changes introduced by your change, including
     1. Change in user-facing APIs.
     2. Addition or removal of property keys.)
   -->
   No.
   
   ### How was this patch tested?
   
   Existing tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#2761] fix(spark): remove unnecessary synchronized [uniffle]

Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on code in PR #2762:
URL: https://github.com/apache/uniffle/pull/2762#discussion_r3542034558


##########
client/src/test/java/org/apache/uniffle/client/impl/FailedBlockSendTrackerTest.java:
##########
@@ -82,16 +82,7 @@ public void getFailedBlockIdsShouldReturnSnapshot() {
     ShuffleServerInfo shuffleServerInfo = new ShuffleServerInfo("host1", 19999);
     ShuffleBlockInfo shuffleBlockInfo =
         new ShuffleBlockInfo(
-            0,
-            0,
-            1L,
-            0,
-            0L,
-            new byte[] {},
-            Lists.newArrayList(shuffleServerInfo),
-            0,
-            0L,
-            0L);
+            0, 0, 1L, 0, 0L, new byte[] {}, Lists.newArrayList(shuffleServerInfo), 0, 0L, 0L);

Review Comment:
   It only fixes the spotless check failure. https://github.com/apache/uniffle/actions/runs/28924971216/job/85810376166?pr=2762



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#2761] fix(spark): remove unnecessary synchronized [uniffle]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2762:
URL: https://github.com/apache/uniffle/pull/2762#issuecomment-4912610052

   ## Test Results
    3 617 files  ±0   3 617 suites  ±0   7h 47m 4s ⏱️ + 1m 10s
    1 265 tests ±0   1 254 ✅ ±0  11 💤 ±0  0 ❌ ±0 
   18 055 runs  ±0  18 018 ✅ ±0  37 💤 ±0  0 ❌ ±0 
   
   Results for commit 03785f72. ± Comparison against base commit 9df64d29.
   
   [test-results]:data:application/gzip;base64,H4sIAJgCTmoC/03MTQ7CIBCG4as0rF0MMPzoZQxSSIhtMRRWxrtLscUuv2cm75v4MLmV3AYuqboMZC0hn/dYkskhLlWYBoaV6j1vH5RJccz7WqxtJvBvz/DajHbxJkxVoINLKaZdUllaVoMQ++xZDVR3+2W5OuBUbfsctXGeQ66DAFdaeMVQGq6MkEx7cwVqR+Do0D2cdRzRjuTzBYdo+7UVAQAA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#2761] fix(spark): remove unnecessary synchronized [uniffle]

Posted by "roryqi (via GitHub)" <gi...@apache.org>.
roryqi merged PR #2762:
URL: https://github.com/apache/uniffle/pull/2762


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org