You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/20 00:39:32 UTC
[GitHub] [beam] udim opened a new pull request #11175: [BEAM-9529] Remove
datastore.v1, googledatastore
udim opened a new pull request #11175: [BEAM-9529] Remove datastore.v1, googledatastore
URL: https://github.com/apache/beam/pull/11175
- Removed googledatastore and proto-google-cloud-datastore-v1 packages.
- Removed v1/datastoreio.py and other v1/ sources that aren't also used by
v1new. The rest were migrated into v1new/.
- Migrated inherited test cases from v1 into v1new test classes.
- Updated datastore_wordcount IT to use v1new. Now also runs on Python 3.
- Added some type hints to v1new/types.py for IDE (PyCharm) ease-of-use.
- Updated Datastore snippet to use v1new, now works for Py3.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] udim commented on issue #11175: [BEAM-9529] Remove
datastore.v1, googledatastore
Posted by GitBox <gi...@apache.org>.
udim commented on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore
URL: https://github.com/apache/beam/pull/11175#issuecomment-601482185
run python 3.7 postcommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] udim commented on issue #11175: [BEAM-9529] Remove
datastore.v1, googledatastore
Posted by GitBox <gi...@apache.org>.
udim commented on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore
URL: https://github.com/apache/beam/pull/11175#issuecomment-601482215
R: @chamikaramj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] udim merged pull request #11175: [BEAM-9529] Remove
datastore.v1, googledatastore
Posted by GitBox <gi...@apache.org>.
udim merged pull request #11175: [BEAM-9529] Remove datastore.v1, googledatastore
URL: https://github.com/apache/beam/pull/11175
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] udim commented on issue #11175: [BEAM-9529] Remove
datastore.v1, googledatastore
Posted by GitBox <gi...@apache.org>.
udim commented on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore
URL: https://github.com/apache/beam/pull/11175#issuecomment-601483548
Note to review: there is very little change to connector code. Most of the changes involve tests, example code, and snippets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] udim edited a comment on issue #11175: [BEAM-9529] Remove
datastore.v1, googledatastore
Posted by GitBox <gi...@apache.org>.
udim edited a comment on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore
URL: https://github.com/apache/beam/pull/11175#issuecomment-601483548
Note to review: there is almost no change to connector code. Most of the changes involve tests, example code, and snippets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] udim edited a comment on issue #11175: [BEAM-9529] Remove
datastore.v1, googledatastore
Posted by GitBox <gi...@apache.org>.
udim edited a comment on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore
URL: https://github.com/apache/beam/pull/11175#issuecomment-601483548
Note to reviewer: there is practically no change to connector code. Most of the changes involve tests, example code, and snippets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] udim edited a comment on issue #11175: [BEAM-9529] Remove
datastore.v1, googledatastore
Posted by GitBox <gi...@apache.org>.
udim edited a comment on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore
URL: https://github.com/apache/beam/pull/11175#issuecomment-601483548
Note to review: there is practically no change to connector code. Most of the changes involve tests, example code, and snippets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] chamikaramj commented on issue #11175: [BEAM-9529] Remove
datastore.v1, googledatastore
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore
URL: https://github.com/apache/beam/pull/11175#issuecomment-606326635
LGTM. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] udim commented on issue #11175: [BEAM-9529] Remove
datastore.v1, googledatastore
Posted by GitBox <gi...@apache.org>.
udim commented on issue #11175: [BEAM-9529] Remove datastore.v1, googledatastore
URL: https://github.com/apache/beam/pull/11175#issuecomment-606333889
Run Python2_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services