You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 10:39:06 UTC
[GitHub] [airflow] ashb opened a new pull request, #23008: Fix TaskFail queries in views after run_id migration
ashb opened a new pull request, #23008:
URL: https://github.com/apache/airflow/pull/23008
Two problems here:
1. TaskFail no longer has a executin_date property -- switch to run_id
2. We weren't joining to DagRun correctly, meaning we'd end up with a
cross-product effect(? Something weird anyway)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #23008: Fix TaskFail queries in views after run_id migration
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #23008:
URL: https://github.com/apache/airflow/pull/23008#issuecomment-1099060547
See also #22934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #23008: Fix TaskFail queries in views after run_id migration
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #23008:
URL: https://github.com/apache/airflow/pull/23008#issuecomment-1099131162
I've taken the tests (and author) from https://github.com/apache/airflow/pull/22934 -- but this way doesn't need a joined load, or to join two tables (TF -> TI -> DR) to get execution_date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #23008: Fix TaskFail queries in views after run_id migration
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #23008:
URL: https://github.com/apache/airflow/pull/23008#discussion_r850442570
##########
airflow/www/views.py:
##########
@@ -2886,21 +2886,22 @@ def duration(self, dag_id, session=None):
min_date = timezone.utc_epoch()
ti_fails = (
session.query(TaskFail)
+ .join(TaskFail.dag_run)
.filter(
TaskFail.dag_id == dag.dag_id,
DagRun.execution_date >= min_date,
DagRun.execution_date <= base_date,
- TaskFail.task_id.in_([t.task_id for t in dag.tasks]),
)
- .all()
)
+ if dag.partial:
+ ti_fails = ti_fails.filter(TaskFail.task_id.in_([t.task_id for t in dag.tasks]))
Review Comment:
Not related to the fix/exception, but it was missing from gantt but done in durations.
(Yes, there is too much duplication between those views.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #23008: Fix TaskFail queries in views after run_id migration
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #23008:
URL: https://github.com/apache/airflow/pull/23008#discussion_r850424733
##########
airflow/www/views.py:
##########
@@ -2886,21 +2886,22 @@ def duration(self, dag_id, session=None):
min_date = timezone.utc_epoch()
ti_fails = (
session.query(TaskFail)
+ .join(TaskFail.dag_run)
.filter(
TaskFail.dag_id == dag.dag_id,
DagRun.execution_date >= min_date,
DagRun.execution_date <= base_date,
- TaskFail.task_id.in_([t.task_id for t in dag.tasks]),
)
- .all()
)
+ if dag.partial:
+ ti_fails = ti_fails.filter(TaskFail.task_id.in_([t.task_id for t in dag.tasks]))
Review Comment:
This one doesn’t seem related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23008: Fix TaskFail queries in views after run_id migration
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23008:
URL: https://github.com/apache/airflow/pull/23008#issuecomment-1099237066
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #23008: Fix TaskFail queries in views after run_id migration
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #23008:
URL: https://github.com/apache/airflow/pull/23008#discussion_r850445383
##########
airflow/www/views.py:
##########
@@ -2886,21 +2886,22 @@ def duration(self, dag_id, session=None):
min_date = timezone.utc_epoch()
ti_fails = (
session.query(TaskFail)
+ .join(TaskFail.dag_run)
.filter(
TaskFail.dag_id == dag.dag_id,
DagRun.execution_date >= min_date,
DagRun.execution_date <= base_date,
- TaskFail.task_id.in_([t.task_id for t in dag.tasks]),
)
- .all()
)
+ if dag.partial:
+ ti_fails = ti_fails.filter(TaskFail.task_id.in_([t.task_id for t in dag.tasks]))
Review Comment:
Wait -- no sorry, mis-remembering.
This is a drive-by-optimization.
There's no point specfying all the task ids if we're just going to include everything. So I now only do it if we're not using the full dag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #23008: Fix TaskFail queries in views after run_id migration
Posted by GitBox <gi...@apache.org>.
ashb merged PR #23008:
URL: https://github.com/apache/airflow/pull/23008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org