You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/09/27 03:09:55 UTC
[GitHub] gianm closed pull request #6337: Fix Kafka Indexing Service notice
handle thread may never terminate
gianm closed pull request #6337: Fix Kafka Indexing Service notice handle thread may never terminate
URL: https://github.com/apache/incubator-druid/pull/6337
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java b/extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java
index 3bcb6e38ec1..dc35361e145 100644
--- a/extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java
+++ b/extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java
@@ -367,8 +367,12 @@ public void start()
exec.submit(
() -> {
try {
- while (!Thread.currentThread().isInterrupted()) {
- final Notice notice = notices.take();
+ long pollTimeout = Math.max(ioConfig.getPeriod().getMillis(), MAX_RUN_FREQUENCY_MILLIS);
+ while (!Thread.currentThread().isInterrupted() && !stopped) {
+ final Notice notice = notices.poll(pollTimeout, TimeUnit.MILLISECONDS);
+ if (notice == null) {
+ continue;
+ }
try {
notice.handle();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org