You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "vinayakphegde (via GitHub)" <gi...@apache.org> on 2025/08/07 18:30:35 UTC

[PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

vinayakphegde opened a new pull request, #7200:
URL: https://github.com/apache/hbase/pull/7200

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "vinayakphegde (via GitHub)" <gi...@apache.org>.
vinayakphegde commented on code in PR #7200:
URL: https://github.com/apache/hbase/pull/7200#discussion_r2383952718


##########
src/main/asciidoc/_chapters/backup_restore.adoc:
##########
@@ -578,32 +578,45 @@ $ hbase backup describe backupId_1467823988425
 // hbase backup delete
 
 [[br.delete.backup]]
-=== Deleting a Backup Image
+=== Deleting Backup Images
 
-This command can be used to delete a backup image which is no longer needed.
+The `hbase backup delete` command deletes backup images that are no longer needed.

Review Comment:
   Thanks for pointing it out @DieterDP-ng I have updated the doc, please review it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar merged PR #7200:
URL: https://github.com/apache/hbase/pull/7200


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #7200:
URL: https://github.com/apache/hbase/pull/7200#discussion_r2272373550


##########
src/main/asciidoc/_chapters/backup_restore.adoc:
##########
@@ -578,32 +578,45 @@ $ hbase backup describe backupId_1467823988425
 // hbase backup delete
 
 [[br.delete.backup]]
-=== Deleting a Backup Image
+=== Deleting Backup Images
 
-This command can be used to delete a backup image which is no longer needed.
+The `hbase backup delete` command deletes backup images that are no longer needed.
+
+[[br.delete.backup.syntax]]
+==== Syntax
 
 [source]
 ----
-$ hbase backup delete <backup_id>
+$ hbase backup delete -l <backup_id1,backup_id2,...>

Review Comment:
   `hbase backup delete <backup_id>` does not work anymore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7200:
URL: https://github.com/apache/hbase/pull/7200#issuecomment-3165327806

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 31s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
   |||| _ Prechecks _ |
   |||| _ master Compile Tests _ |
   |||| _ Patch Compile Tests _ |
   |||| _ Other Tests _ |
   |  |   |   1m 29s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7200/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/7200 |
   | Optional Tests |  |
   | uname | Linux b8e719dcd6c6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 07f7103923f3d895bd2e07540ceb5ad053459978 |
   | Max. process+thread count | 42 (vs. ulimit of 30000) |
   | modules | C: . U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7200/1/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "vinayakphegde (via GitHub)" <gi...@apache.org>.
vinayakphegde commented on code in PR #7200:
URL: https://github.com/apache/hbase/pull/7200#discussion_r2272436069


##########
src/main/asciidoc/_chapters/backup_restore.adoc:
##########
@@ -578,32 +578,45 @@ $ hbase backup describe backupId_1467823988425
 // hbase backup delete
 
 [[br.delete.backup]]
-=== Deleting a Backup Image
+=== Deleting Backup Images
 
-This command can be used to delete a backup image which is no longer needed.
+The `hbase backup delete` command deletes backup images that are no longer needed.
+
+[[br.delete.backup.syntax]]
+==== Syntax
 
 [source]
 ----
-$ hbase backup delete <backup_id>
+$ hbase backup delete -l <backup_id1,backup_id2,...>

Review Comment:
   > we are good to merge this
   
   can we wait for one more review, just to be on the safer side. :) 
   
   > also please analyse that this is not a backward incompatible change.
   
   this is just a documentation update, right? But I will still check that. maybe mention a note regarding that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #7200:
URL: https://github.com/apache/hbase/pull/7200#discussion_r2272541107


##########
src/main/asciidoc/_chapters/backup_restore.adoc:
##########
@@ -578,32 +578,45 @@ $ hbase backup describe backupId_1467823988425
 // hbase backup delete
 
 [[br.delete.backup]]
-=== Deleting a Backup Image
+=== Deleting Backup Images
 
-This command can be used to delete a backup image which is no longer needed.
+The `hbase backup delete` command deletes backup images that are no longer needed.
+
+[[br.delete.backup.syntax]]
+==== Syntax
 
 [source]
 ----
-$ hbase backup delete <backup_id>
+$ hbase backup delete -l <backup_id1,backup_id2,...>

Review Comment:
   
   > > also please analyse that this is not a backward incompatible change.
   > 
   > this is just a documentation update, right? But I will still check that. maybe mention a note regarding that?
   
   Not as part of this ticket, please create a new JIRA for this.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7200:
URL: https://github.com/apache/hbase/pull/7200#issuecomment-3165381496

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 41s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   |||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 47s |  |  master passed  |
   | +0 :ok: |  refguide  |   3m 55s |  |  branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.  |
   | +1 :green_heart: |  spotless  |   1m 20s |  |  branch has no errors when running spotless:check.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 50s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks issues.  |
   | +0 :ok: |  refguide  |   3m  6s |  |  patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.  |
   | +1 :green_heart: |  spotless  |   1m 30s |  |  patch has no errors when running spotless:check.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 29s |  |  The patch does not generate ASF License warnings.  |
   |  |   |  22m 37s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7200/1/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/7200 |
   | Optional Tests | dupname asflicense codespell detsecrets refguide spotless |
   | uname | Linux 7be53458dcc0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 07f7103923f3d895bd2e07540ceb5ad053459978 |
   | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-7200/1/yetus-general-check/output/branch-site/book.html |
   | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-7200/1/yetus-general-check/output/patch-site/book.html |
   | Max. process+thread count | 91 (vs. ulimit of 30000) |
   | modules | C: . U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7200/1/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #7200:
URL: https://github.com/apache/hbase/pull/7200#discussion_r2272411765


##########
src/main/asciidoc/_chapters/backup_restore.adoc:
##########
@@ -578,32 +578,45 @@ $ hbase backup describe backupId_1467823988425
 // hbase backup delete
 
 [[br.delete.backup]]
-=== Deleting a Backup Image
+=== Deleting Backup Images
 
-This command can be used to delete a backup image which is no longer needed.
+The `hbase backup delete` command deletes backup images that are no longer needed.
+
+[[br.delete.backup.syntax]]
+==== Syntax
 
 [source]
 ----
-$ hbase backup delete <backup_id>
+$ hbase backup delete -l <backup_id1,backup_id2,...>

Review Comment:
   also please analyse that this is not a backward incompat change. i am not sure in which version the delete command was added, but if it worked before in say hbase 2, it should still work unless we had a deprecation cycle. this may break user scripts with upgrade otherwise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "DieterDP-ng (via GitHub)" <gi...@apache.org>.
DieterDP-ng commented on code in PR #7200:
URL: https://github.com/apache/hbase/pull/7200#discussion_r2387440844


##########
src/main/asciidoc/_chapters/backup_restore.adoc:
##########
@@ -578,32 +578,45 @@ $ hbase backup describe backupId_1467823988425
 // hbase backup delete
 
 [[br.delete.backup]]
-=== Deleting a Backup Image
+=== Deleting Backup Images
 
-This command can be used to delete a backup image which is no longer needed.
+The `hbase backup delete` command deletes backup images that are no longer needed.

Review Comment:
   LGTM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7200:
URL: https://github.com/apache/hbase/pull/7200#issuecomment-3341342701

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 28s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   |||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 17s |  |  master passed  |
   | +0 :ok: |  refguide  |   2m 24s |  |  branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.  |
   | +1 :green_heart: |  spotless  |   0m 49s |  |  branch has no errors when running spotless:check.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  8s |  |  the patch passed  |
   | -0 :warning: |  blanks  |   0m  0s | [/blanks-eol.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7200/2/artifact/yetus-general-check/output/blanks-eol.txt) |  The patch has 5 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | +0 :ok: |  refguide  |   2m  4s |  |  patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.  |
   | +1 :green_heart: |  spotless  |   0m 45s |  |  patch has no errors when running spotless:check.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 11s |  |  The patch does not generate ASF License warnings.  |
   |  |   |  14m 31s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7200/2/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/7200 |
   | Optional Tests | dupname asflicense codespell detsecrets refguide spotless |
   | uname | Linux 40d1dfc2e480 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 13bd9f64b247b7df157cba5a65b9c0a52a762e06 |
   | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-7200/2/yetus-general-check/output/branch-site/book.html |
   | refguide | https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-7200/2/yetus-general-check/output/patch-site/book.html |
   | Max. process+thread count | 82 (vs. ulimit of 30000) |
   | modules | C: . U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7200/2/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #7200:
URL: https://github.com/apache/hbase/pull/7200#discussion_r2272401379


##########
src/main/asciidoc/_chapters/backup_restore.adoc:
##########
@@ -578,32 +578,45 @@ $ hbase backup describe backupId_1467823988425
 // hbase backup delete
 
 [[br.delete.backup]]
-=== Deleting a Backup Image
+=== Deleting Backup Images
 
-This command can be used to delete a backup image which is no longer needed.
+The `hbase backup delete` command deletes backup images that are no longer needed.
+
+[[br.delete.backup.syntax]]
+==== Syntax
 
 [source]
 ----
-$ hbase backup delete <backup_id>
+$ hbase backup delete -l <backup_id1,backup_id2,...>

Review Comment:
   cool thanks for confirming. we are good to merge this and https://github.com/apache/hbase/pull/7199?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #7200:
URL: https://github.com/apache/hbase/pull/7200#issuecomment-3341331964

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 31s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
   |||| _ Prechecks _ |
   |||| _ master Compile Tests _ |
   |||| _ Patch Compile Tests _ |
   |||| _ Other Tests _ |
   |  |   |   1m 22s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7200/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/7200 |
   | Optional Tests |  |
   | uname | Linux 0a8708ae7b57 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 13bd9f64b247b7df157cba5a65b9c0a52a762e06 |
   | Max. process+thread count | 39 (vs. ulimit of 30000) |
   | modules | C: . U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7200/2/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "DieterDP-ng (via GitHub)" <gi...@apache.org>.
DieterDP-ng commented on code in PR #7200:
URL: https://github.com/apache/hbase/pull/7200#discussion_r2284967371


##########
src/main/asciidoc/_chapters/backup_restore.adoc:
##########
@@ -578,32 +578,45 @@ $ hbase backup describe backupId_1467823988425
 // hbase backup delete
 
 [[br.delete.backup]]
-=== Deleting a Backup Image
+=== Deleting Backup Images
 
-This command can be used to delete a backup image which is no longer needed.
+The `hbase backup delete` command deletes backup images that are no longer needed.

Review Comment:
   Two thing that surprised me when experimenting with backup-restore, and would in my opinion be useful to add, are the following:
   
   1) Deleting a backup will affect all following incremental backups (in the same backup root) up to the next full backup. This might lead to unexpected data loss.
   
   An example: assume you do a full backup every 2 weeks, and a daily incremental backup. If you do `hbase backup delete -k 7` and the full backup is older than 7 days, you'll have effectively cleared all incremental backups as well. (The backup will still be listed, but the backup data inside it will be gone.)
   
   2) If the most recent backup is an incremental backup, and you delete it, you should do a full backup next. If you do an incremental backup instead, the backup image may miss data that is present in HBase. (Logged as [HBASE-28084](https://issues.apache.org/jira/browse/HBASE-28084))



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "vinayakphegde (via GitHub)" <gi...@apache.org>.
vinayakphegde commented on code in PR #7200:
URL: https://github.com/apache/hbase/pull/7200#discussion_r2272436069


##########
src/main/asciidoc/_chapters/backup_restore.adoc:
##########
@@ -578,32 +578,45 @@ $ hbase backup describe backupId_1467823988425
 // hbase backup delete
 
 [[br.delete.backup]]
-=== Deleting a Backup Image
+=== Deleting Backup Images
 
-This command can be used to delete a backup image which is no longer needed.
+The `hbase backup delete` command deletes backup images that are no longer needed.
+
+[[br.delete.backup.syntax]]
+==== Syntax
 
 [source]
 ----
-$ hbase backup delete <backup_id>
+$ hbase backup delete -l <backup_id1,backup_id2,...>

Review Comment:
   > we are good to merge this
   can we wait for one more review, just to be on the safer side. :) 
   
   > also please analyse that this is not a backward incompatible change.
   this is just a documentation update, right? But I will still check that. maybe mention a note regarding that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "vinayakphegde (via GitHub)" <gi...@apache.org>.
vinayakphegde commented on PR #7200:
URL: https://github.com/apache/hbase/pull/7200#issuecomment-3184408286

   @DieterDP-ng can you review this? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-29505 [DOC] Document Enhanced Options for Backup Delete Command [hbase]

Posted by "vinayakphegde (via GitHub)" <gi...@apache.org>.
vinayakphegde commented on code in PR #7200:
URL: https://github.com/apache/hbase/pull/7200#discussion_r2272395158


##########
src/main/asciidoc/_chapters/backup_restore.adoc:
##########
@@ -578,32 +578,45 @@ $ hbase backup describe backupId_1467823988425
 // hbase backup delete
 
 [[br.delete.backup]]
-=== Deleting a Backup Image
+=== Deleting Backup Images
 
-This command can be used to delete a backup image which is no longer needed.
+The `hbase backup delete` command deletes backup images that are no longer needed.
+
+[[br.delete.backup.syntax]]
+==== Syntax
 
 [source]
 ----
-$ hbase backup delete <backup_id>
+$ hbase backup delete -l <backup_id1,backup_id2,...>

Review Comment:
   No, it does not work. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org