[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2222: Use a few integer types from the compiler

[GitBox <gi...@apache.org>]

v01d commented on a change in pull request #2222:
URL: https://github.com/apache/incubator-nuttx/pull/2222#discussion_r520624418



##########
File path: arch/arm/src/lpc214x/lpc214x_serial.c
##########
@@ -89,7 +90,7 @@ static int  up_attach(struct uart_dev_s *dev);
 static void up_detach(struct uart_dev_s *dev);
 static int  up_interrupt(int irq, void *context, void *arg);
 static int  up_ioctl(struct file *filep, int cmd, unsigned long arg);
-static int  up_receive(struct uart_dev_s *dev, uint32_t *status);
+static int  up_receive(struct uart_dev_s *dev, unsigned int *status);

Review comment:
       I might be a bit out of context (I think you already worked on similar changes in other PRs) but what is the motivation behind this change? I understand that since you know which platform you are in you already now that unsigned int is 32 bit, so no need to explicitly say so. However, aren't we then introducing inconsistent practices in the code? Right now uint32_t is used everywhere and it would be wrong to see some functions use one type and others another type (regardless of actually being the same size).
   Also, why is uint32_t a problem? Isn't this definition standard? (defined in stdint.h after all)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org