You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/05 15:39:36 UTC
[GitHub] [airflow] potiuk opened a new pull request #20687: Fix main failing on wrong inheritance hierarchy
potiuk opened a new pull request #20687:
URL: https://github.com/apache/airflow/pull/20687
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005877568
> > No-one fault - selective checks did not run the tests as it was "provider-only" change (theorethically).
>
> yep #20332 had a green build. We need `test_core_to_contrib` to run also on any change in `providers`. I think also this file name is a bit misleading.. it has also entries for stuff other than contrib. it's more like a general deprecation check.
Agree - we even have a special category for that "Always" :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005859480
> No-one fault - selective checks did not run the tests as it was "provider-only" change (theorethically).
yep https://github.com/apache/airflow/pull/20332 had a green build.
We need `test_core_to_contrib` to run also on any change in `providers`.
I think also this file name is a bit misleading.. it has also entries for stuff other than contrib. it's more like a general deprecation check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005836955
Failed with
tests/core/test_core_to_contrib.py::TestMovingCoreToContrib::test_is_subclass_256_airflow_providers_amazon_aws_operators_ecs_ECSOperator: TypeError: Protocols can only inherit from other protocols, got <class 'airflow.providers.amazon.aws.operators.ecs.ECSProtocol'>
tests/core/test_core_to_contrib.py::TestMovingCoreToContrib::test_warning_on_import_256_airflow_providers_amazon_aws_operators_ecs_ECSOperator: TypeError: Protocols can only inherit from other protocols, got <class 'airflow.providers.amazon.aws.operators.ecs.ECSProtocol'>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005840772
> But `ECSProtocol` is a protocol...
I know . But It helped for now. I tihnk there is some problem with the type check. Since it is a deprecated class, I preferred to quickly fix it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005842984
I’m going to close this one since this is only a subset of #20670, and we should choose from either it or #20699 instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #20687:
URL: https://github.com/apache/airflow/pull/20687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005838773
But `ECSProtocol` is a protocol...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005838730
No-one fault - selective checks did not run the tests as it was "provider-only" change (theorethically).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005841596
See also #20669 and #20670.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005838730
No-one fault - selective checks did not run the tests as it is "provider-only" change (theorethically).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005884490
PR in #20691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005842177
```
for base in cls.__bases__:
if not (base in (object, Generic) or
base.__module__ == 'collections.abc' and
base.__name__ in _PROTO_WHITELIST or
isinstance(base, _ProtocolMeta) and base._is_protocol):
raise TypeError('Protocols can only inherit from other'
> ' protocols, got %r' % base)
E TypeError: Protocols can only inherit from other protocols, got <class 'airf
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr edited a comment on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005842984
I’m going to close this one since this is only a subset of #20670, and we should choose from either it or #20669 instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #20687: Fix main failing on wrong inheritance hierarchy
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005841083
So is `EcsProtocol`. By inheriting from `EcsProtocol`, `ECSProtocol` is already automatically a protocol, and inheriting from `Protocol` is redundant either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org