[jira] [Commented] (ISIS-1372) Change BackgroundCommandService to work with Aim DTO; centralize logic for creating Aim DTOs within new domain service (CommandMementoService)

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236721#comment-15236721 ] 

ASF subversion and git services commented on ISIS-1372:
-------------------------------------------------------

Commit 9b35ceb9d1e1272fcbf864e2ea7906f824f0308f in isis's branch refs/heads/ISIS-1291 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9b35ceb ]

ISIS-1372: just moved BacgroundService#asActionInvocationMemento over to new CommandMementoService#asActionInvocationMemento.


> Change BackgroundCommandService to work with Aim DTO; centralize logic for creating Aim DTOs within new domain service (CommandMementoService)
> ----------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-1372
>                 URL: https://issues.apache.org/jira/browse/ISIS-1372
>             Project: Isis
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 1.12.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.13.0
>
>
> Currently the ActionInvocationFacetForDomainEventAbstract - to support background commands - calls the non-API method on BackgroundServiceDefault.  The returned ActionInvocationMemento is serialized and persisted by BackgroundCommandService impl.  To actually run in the background, the command object is rehydrated and passed to BackgroundExecution.
> We also want to be able to republish events (via PublishingService2); this requires that the command memento holds ActionInvocationMementoDtos rather than the current "legacy" ActionInvocationMemento.
> Currently the logic to pass to relevant info to the PublshingService - namely, the EventMetadata object - is hard-wired within IsisTransaction.  
> This ticket is to move the responsibility to create command action invocation memento DTOs into a new service, CommandMementoService, and have it also be able to create EventMetadata objects too.  Thus the IsisTransaction becomes much thinner, and also allows PublishingServiceMq to reuse the CommandMementoService.
> ~~~
> said another way: move code from IsisTransaction (to create the Event metadata) and also the code in PublishingServiceMq (to create action invocation memento DTOs from an event metadata) into this new service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)