You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2026/10/16 17:05:42 UTC

[I] [C++] Building Arrow via FetchContent can fail with versions older than CMake 3.30 [arrow]

raulcd opened a new issue, #53995:
URL: https://github.com/apache/arrow/issues/53995

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   As seen on the iceberg-cpp report here:
   - https://github.com/apache/iceberg-cpp/issues/1028
   
   Building Arrow via FetchContent on iceberg with older CMake fails. This is because:
   > For older versions of CMake the variable arrow_SOURCE_DIR is overriden by FetchContent's one because project(arrow) sets it as a cache variable while FetchContent sets a normal variable with precedence. Arrow can't find thirdparty/versions.txt because it is pointing to the tarball root instead of the cpp subfolder. See policy https://cmake.org/cmake/help/latest/policy/CMP0180.html
   > We should fix upstream Arrow so it does not rely on arrow_SOURCE_DIR to allow older CMake builds.
   
   See the PR I did here with the patch:
   - https://github.com/apache/iceberg-cpp/pull/1029
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [C++] Building Arrow via FetchContent can fail with versions older than CMake 3.30 [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #53995:
URL: https://github.com/apache/arrow/issues/53995#issuecomment-6225656067

   +1
   
   Let's apply the change in apache/arrow too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [C++] Building Arrow via FetchContent can fail with versions older than CMake 3.30 [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #53995: [C++] Building Arrow via FetchContent can fail with versions older than CMake 3.30
URL: https://github.com/apache/arrow/issues/53995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [C++] Building Arrow via FetchContent can fail with versions older than CMake 3.30 [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #53995:
URL: https://github.com/apache/arrow/issues/53995#issuecomment-6486256972

   Issue resolved by pull request 54573
   https://github.com/apache/arrow/pull/54573


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [C++] Building Arrow via FetchContent can fail with versions older than CMake 3.30 [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #53995:
URL: https://github.com/apache/arrow/issues/53995#issuecomment-6220665405

   @kou what do you think about this, the patch I apply there seems to fix the issues:
   ```diff
   --- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
   +++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
   @@ -365,7 +365,7 @@
    # ----------------------------------------------------------------------
    # Thirdparty versions, environment variables, source URLs
   
   -set(THIRDPARTY_DIR "${arrow_SOURCE_DIR}/thirdparty")
   +set(THIRDPARTY_DIR "${ARROW_SOURCE_DIR}/thirdparty")
   
    add_library(arrow::flatbuffers INTERFACE IMPORTED)
    target_include_directories(arrow::flatbuffers
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org