You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/07/20 05:23:03 UTC
Review Request 67993: Avoid resource copying while serving state json.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67993/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Benno Evers.
Repository: mesos
Description
-------
The state serving code was constructing `Resources` wrappers in
order to jsonify resources. This incurs a copy of the underlying
Resource objects which is unnecessary and can be costly. This
removes the copy by proving a direct way to jsonify
`RepeatedPtrField<Resource>`.
This shows a small 10-15% reduction in the master StateQuery
benchmark timings:
min q1 q3 max
baseline 3.48 3.54 4.12 4.40
after this patch 2.82 3.11 3.31 3.71
Diffs
-----
src/common/http.hpp 9d2b01f5cb0f787d1ea84d298b25b7e0d072cc66
src/common/http.cpp 9dfbfd12e22b215a24d0598b5c87d96807dc7a6c
src/master/http.cpp c855de1b7bb71cb455d111fcd71c4486f421f2c2
src/slave/http.cpp cf93c487b0936baf70238ffe6eba62f752ea9a81
Diff: https://reviews.apache.org/r/67993/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 67993: Avoid resource copying while serving state
json.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67993/#review206275
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On July 20, 2018, 5:23 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67993/
> -----------------------------------------------------------
>
> (Updated July 20, 2018, 5:23 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The state serving code was constructing `Resources` wrappers in
> order to jsonify resources. This incurs a copy of the underlying
> Resource objects which is unnecessary and can be costly. This
> removes the copy by proving a direct way to jsonify
> `RepeatedPtrField<Resource>`.
>
> This shows a small 10-15% reduction in the master StateQuery
> benchmark timings:
>
> min q1 q3 max
> baseline 3.48 3.54 4.12 4.40
> after this patch 2.82 3.11 3.31 3.71
>
>
> Diffs
> -----
>
> src/common/http.hpp 9d2b01f5cb0f787d1ea84d298b25b7e0d072cc66
> src/common/http.cpp 9dfbfd12e22b215a24d0598b5c87d96807dc7a6c
> src/master/http.cpp c855de1b7bb71cb455d111fcd71c4486f421f2c2
> src/slave/http.cpp cf93c487b0936baf70238ffe6eba62f752ea9a81
>
>
> Diff: https://reviews.apache.org/r/67993/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 67993: Avoid resource copying while serving state
json.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67993/#review206259
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 67987.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67987`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1960/mesos-review-67993
Relevant logs:
- [apply-review-67987-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1960/mesos-review-67993/logs/apply-review-67987-stdout.log):
```
error: missing binary patch data for '3rdparty/rapidjson-1.1.0.tar.gz'
error: binary patch does not apply to '3rdparty/rapidjson-1.1.0.tar.gz'
error: 3rdparty/rapidjson-1.1.0.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On July 20, 2018, 5:23 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67993/
> -----------------------------------------------------------
>
> (Updated July 20, 2018, 5:23 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The state serving code was constructing `Resources` wrappers in
> order to jsonify resources. This incurs a copy of the underlying
> Resource objects which is unnecessary and can be costly. This
> removes the copy by proving a direct way to jsonify
> `RepeatedPtrField<Resource>`.
>
> This shows a small 10-15% reduction in the master StateQuery
> benchmark timings:
>
> min q1 q3 max
> baseline 3.48 3.54 4.12 4.40
> after this patch 2.82 3.11 3.31 3.71
>
>
> Diffs
> -----
>
> src/common/http.hpp 9d2b01f5cb0f787d1ea84d298b25b7e0d072cc66
> src/common/http.cpp 9dfbfd12e22b215a24d0598b5c87d96807dc7a6c
> src/master/http.cpp c855de1b7bb71cb455d111fcd71c4486f421f2c2
> src/slave/http.cpp cf93c487b0936baf70238ffe6eba62f752ea9a81
>
>
> Diff: https://reviews.apache.org/r/67993/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 67993: Avoid resource copying while serving state
json.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67993/#review206411
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On July 20, 2018, 5:23 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67993/
> -----------------------------------------------------------
>
> (Updated July 20, 2018, 5:23 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benno Evers.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The state serving code was constructing `Resources` wrappers in
> order to jsonify resources. This incurs a copy of the underlying
> Resource objects which is unnecessary and can be costly. This
> removes the copy by proving a direct way to jsonify
> `RepeatedPtrField<Resource>`.
>
> This shows a small 10-15% reduction in the master StateQuery
> benchmark timings:
>
> min q1 q3 max
> baseline 3.48 3.54 4.12 4.40
> after this patch 2.82 3.11 3.31 3.71
>
>
> Diffs
> -----
>
> src/common/http.hpp 9d2b01f5cb0f787d1ea84d298b25b7e0d072cc66
> src/common/http.cpp 9dfbfd12e22b215a24d0598b5c87d96807dc7a6c
> src/master/http.cpp c855de1b7bb71cb455d111fcd71c4486f421f2c2
> src/slave/http.cpp cf93c487b0936baf70238ffe6eba62f752ea9a81
>
>
> Diff: https://reviews.apache.org/r/67993/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>