[GitHub] [incubator-superset] kristw commented on a change in pull request #9562: Add raw number/integer option to d3 number formats

[GitBox <gi...@apache.org>]

kristw commented on a change in pull request #9562: Add raw number/integer option to d3 number formats
URL: https://github.com/apache/incubator-superset/pull/9562#discussion_r409913915
 
 

 ##########
 File path: superset-frontend/src/explore/controls.jsx
 ##########
 @@ -83,6 +83,8 @@ export const PRIMARY_COLOR = { r: 0, g: 122, b: 135, a: 1 };
 // input choices & options
 export const D3_FORMAT_OPTIONS = [
   ['SMART_NUMBER', 'Adaptative formating'],
+  [' ', 'Original number'],
+  [',d', ',d (12345.432 => 12,345)'],
 
 Review comment:
   How about changing the description 
   
   `,d (12345.432 => 12,345)` to `Integer (12345.432 => 12,345)`
   
   (optional) There are also constants in the package.
   
   ```ts
   import { NumberFormats } from '@superset-ui/number-format';
   NumberFormats.INTEGER
   NumberFormats.SIGNED_INTEGER
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org